chore: remove Depends="pbis-open"

[yixinshark]

as title

Log: as title

Summary by Sourcery

Build:

• Remove pbis-open dependency from the Debian build configuration.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the dependency on 'pbis-open' from the debian package rules.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Removed dependency on pbis-open	Remove the Depends line specifying pbis-open	debian/rules

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

在提供的代码片段中，存在一些潜在的问题和改进点：

1. 代码格式和风格：

   • 在override_dh_auto_configure之后，多了一个空行，建议删除以保持代码整洁。
   • ifeq语句的缩进不一致，建议统一缩进以增强可读性。

2. 逻辑和功能：

   • ifeq ($(SYSTYPE), Professional)和ifeq ($(DEB_BUILD_ARCH), amd64)两个条件判断是嵌套的，如果SYSTYPE不是Professional，那么DEB_BUILD_ARCH的判断将不会被执行。这可能不是预期的行为，需要确认是否需要这样的逻辑。
   • 如果SYSTYPE不是Professional，那么override_dh_gencontrol和dh_gencontrol的代码将不会被执行。如果这是预期的行为，那么代码是正确的。如果不是，则需要调整逻辑。

3. 代码质量：

   • 如果override_dh_gencontrol和dh_gencontrol的代码是必要的，建议将它们移到override_dh_auto_configure之后，而不是单独放在ifeq语句中。这样可以避免不必要的条件判断，提高代码的可读性和维护性。

4. 性能：

   • 没有明显的性能问题，因为这段代码主要是配置和依赖管理。

5. 安全性：

   • 没有涉及到安全性相关的代码，因此没有安全性的建议。

综合以上分析，改进后的代码可能如下：

override_dh_auto_configure:
	dh_auto_configure -- \
		-DWAIT_DEEPIN_ACCOUNTS_SERVICE=1 \
		-DDDE_SESSION_SHELL_SNIPE=1

ifeq ($(SYSTYPE), Professional)
ifeq ($(DEB_BUILD_ARCH), amd64)
override_dh_gencontrol:
	dh_gencontrol -- -Vdist:Depends="pbis-open"
endif
endif

请注意，这只是一个建议，具体实现需要根据实际需求进行调整。

[sourcery-ai]

Hey @yixinshark - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robertkill, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment