sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#31

Summary by Sourcery

Sync changes from linuxdeepin/dde-session-shell and improve UserFrameList widget initialization and layout constraints

Enhancements:

• Assign m_centerWidget a parent to ensure proper widget ownership
• Limit m_centerWidget's maximum height to the scroll area height in updateLayout

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates UserFrameList to correctly parent its central widget and align its maximum height with the scroll area during layout recalculations.

Class diagram for updated UserFrameList structure

classDiagram
    class UserFrameList {
        - QWidget* m_centerWidget
        - DFlowLayout* m_flowLayout
        - QScrollArea* m_scrollArea
        + void initUI()
        + void updateLayout(int width)
    }
    UserFrameList --> QWidget : m_centerWidget
    UserFrameList --> DFlowLayout : m_flowLayout
    UserFrameList --> QScrollArea : m_scrollArea

    %% Highlight changes
    %% m_centerWidget is now constructed with 'this' as parent
    %% updateLayout now sets m_centerWidget maximum height to m_scrollArea height

Loading

File-Level Changes

Change	Details	Files
Assign m_centerWidget a proper parent at creation	Instantiate m_centerWidget with 'this' as its parent	src/session-widgets/userframelist.cpp
Constrain center widget height to scroll area size	Set m_centerWidget maximum height to scroll area height when item count fits	src/session-widgets/userframelist.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

我对这段代码进行审查，提供以下改进意见：

1. 语法逻辑方面：

• m_centerWidget 的创建已经正确地传递了父窗口指针 this，这有助于内存管理，避免内存泄漏。
• updateLayout 函数中的逻辑基本合理，但可以考虑添加边界条件检查，比如 width 参数的有效性检查。

2. 代码质量方面：

• 代码结构清晰，变量命名规范，遵循了Qt的命名约定。
• 建议为 countWidth 和 userWidgetHeight 等变量添加注释，说明它们的计算方式和用途，提高代码可读性。
• updateLayout 函数中硬编码的数值 + 20 和 * 2 建议定义为常量，以提高代码的可维护性。

3. 代码性能方面：

• 在 updateLayout 函数中，m_flowLayout->count() 的调用可能会触发布局计算，如果频繁调用可能会影响性能。可以考虑缓存这个值。
• 滚动区域的大小调整可能会触发多次重绘，可以考虑使用 setUpdatesEnabled(false/true) 来临时禁用更新，完成所有布局调整后再启用。

4. 代码安全方面：

• 建议在 updateLayout 函数中添加参数有效性检查，确保 width 是非负值。
• 如果 userWidgetHeight 可能为负值，应该添加检查以防止出现不合理的尺寸设置。

改进建议代码示例：

// 在类定义中添加常量
static const int UserFrameListVerticalMargin = 20;
static const int DoubleLayoutMultiplier = 2;

void UserFrameList::updateLayout(int width)
{
    // 参数有效性检查
    if (width <= 0) {
        qWarning() << "Invalid width provided to updateLayout:" << width;
        return;
    }

    const int count = m_flowLayout->count();  // 缓存count值
    const int countWidth = /* 计算逻辑 */;
    const int userWidgetHeight = /* 计算逻辑 */;
    
    // 禁用更新以提高性能
    setUpdatesEnabled(false);
    
    if (countWidth > 0) {
        if (count <= count) {
            m_scrollArea->setFixedSize(countWidth, userWidgetHeight + UserFrameListVerticalMargin);
            m_centerWidget->setMaximumHeight(m_scrollArea->height());
        } else {
            m_scrollArea->setFixedSize(countWidth, (userWidgetHeight + UserFrameSpacing) * DoubleLayoutMultiplier);
        }
    }
    
    // 重新启用更新
    setUpdatesEnabled(true);
}

这些改进可以提高代码的健壮性、可读性和性能，同时减少潜在的错误。

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment