Skip to content

Conversation

@hillwoodroc
Copy link

This ensures correct installation and runtime lookup on both lib and lib64 based systems.

Log:

  • Define CMAKE_INSTALL_FULL_LIBDIR in top-level CMakeLists.txt
  • Replace hardcoded 'lib/dde-session-shell/modules' with '${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules' in all plugin CMakeLists
  • Update modules_loader.cpp to use CMAKE_INSTALL_FULL_LIBDIR for locating modules and configs

This ensures correct installation and runtime lookup on both lib and
lib64 based systems.

Log:
- Define CMAKE_INSTALL_FULL_LIBDIR in top-level CMakeLists.txt
- Replace hardcoded 'lib/dde-session-shell/modules' with
  '${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules' in all plugin
  CMakeLists
- Update modules_loader.cpp to use CMAKE_INSTALL_FULL_LIBDIR for
  locating modules and configs
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @hillwoodroc, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants