Skip to content

Conversation

@yixinshark
Copy link
Contributor

as title

Log: as title
Pms: BUG-314341

as title

Log: as title
Pms: BUG-314341
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • #ifndef ENABLE_DSS_SNIPE宏定义下,updateGeometry()函数被调用两次,应该移除一次。
  • raise()函数在#else分支中没有被调用,如果这是必要的,应该添加调用。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Apr 23, 2025
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#3
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

activateWindow();
}

#ifndef ENABLE_DSS_SNIPE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是还可以一个函数而非宏 , 类似 ENABLE_DSS_SNIPE的功能,动态判断,

@yixinshark yixinshark merged commit c3ea5d7 into linuxdeepin:master Apr 25, 2025
14 of 15 checks passed
yixinshark pushed a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Apr 25, 2025
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants