Skip to content

Conversation

@waterlovemelon
Copy link
Contributor

Add login-gesture plugin in v20

V20增加手势登录插件

Log:
Influence: Compilation and packaging will add the login-gesture plugin in v20
Change-Id: I1aa69887f8735f9c099b62819e47156b7fdd8445

Add login-gesture plugin in v20

V20增加手势登录插件

Log:
Influence: Compilation and packaging will add the login-gesture plugin in v20
Change-Id: I1aa69887f8735f9c099b62819e47156b7fdd8445
deepin-ci-robot added a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Sep 8, 2025
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#35
@deepin-ci-robot
Copy link

deepin pr auto review

这段diff显示了对CMakeLists.txt文件的修改,主要是关于子目录的添加和注释状态的更改。我来分析一下这个变更:

  1. 变更内容:

    • 取消了对"login-gesture"子目录的注释(从# add_subdirectory("login-gesture")改为add_subdirectory("login-gesture")
    • 将"login-gesture"子目录的添加移到了条件语句if (DISABLE_DSS_SNIPE)内部
    • 保持了"one-key-login"在条件语句内
    • 其他子目录(examples、assist_login)保持注释状态不变
  2. 可能的影响:

    • "login-gesture"模块现在只在DISABLE_DSS_SNIPE条件为真时才会被构建
    • 这可能意味着login-gesture模块依赖于DSS_SNIPE功能,或者两者有某种关联
  3. 改进建议:

    • 如果"login-gesture"确实依赖于DSS_SNIPE功能,这个修改是合理的
    • 但如果没有这种依赖关系,将login-gesture移入条件内部可能会导致不必要的构建限制
    • 建议添加注释说明为什么login-gesture需要放在这个条件内,例如:
      if (DISABLE_DSS_SNIPE)
          # one-key-login和login-gesture都依赖于DSS_SNIPE功能
          add_subdirectory(one-key-login)
          add_subdirectory("login-gesture")
      endif()
    • 考虑使用更具描述性的变量名,如ENABLE_DSS_SNIPE而不是DISABLE_DSS_SNIPE,因为通常我们使用启用标志而非禁用标志来控制功能
  4. 代码质量:

    • 当前代码格式良好,缩进一致
    • 建议保持一致的引号使用风格(目前有些地方用了引号,有些没有)
  5. 安全性:

    • 这个变更本身不涉及安全性问题
    • 需要确保"login-gesture"模块在DSS_SNIPE禁用的情况下不会导致运行时问题

总的来说,这个修改看起来是为了根据DSS_SNIPE功能的启用/禁用状态来控制相关模块的构建。如果这种依赖关系是设计上的要求,那么这个修改是合理的,但建议添加适当的注释以解释这种依赖关系。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: waterlovemelon, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@waterlovemelon waterlovemelon merged commit 024678d into linuxdeepin:master Sep 9, 2025
14 of 15 checks passed
yixinshark pushed a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Sep 12, 2025
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#35
yixinshark pushed a commit to linuxdeepin/dde-session-shell-snipe that referenced this pull request Sep 12, 2025
Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants