-
Notifications
You must be signed in to change notification settings - Fork 12
feat: improve the logic of obtaining icons #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin-ci-robot
added a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
May 20, 2025
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#9
deepin-ci-robot
added a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
May 20, 2025
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#9
deepin-ci-robot
added a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
May 20, 2025
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#9
yixinshark
reviewed
May 20, 2025
yixinshark
reviewed
May 20, 2025
1. Added support for fetching icons from ApplicationManager DBus interface 2. Special handling for Linglong containerized apps where executable path isn't accessible 3. Added fallback to default icon when theme icon not available 4. Implemented DBus communication to get app icons from desktop entry 5. Added necessary header includes and DBus constants The changes were necessary because: 1. Linglong apps run in containers making their executable paths inaccessible 2. Previous implementation couldn't properly display icons for containerized apps 3. New solution uses ApplicationManager DBus interface as reliable icon source 4. Maintains backward compatibility with regular applications feat: 改进玲珑应用的图标处理 1. 添加从ApplicationManager DBus接口获取图标支持 2. 对玲珑容器化应用特殊处理,其可执行路径无法访问 3. 添加主题图标不可用时的默认图标回退机制 4. 实现通过DBus从桌面条目获取应用图标 5. 添加必要的头文件包含和DBus常量 修改原因: 1. 玲珑应用运行在容器中导致其可执行路径无法访问 2. 原实现无法正确显示容器化应用的图标 3. 新方案使用ApplicationManager DBus接口作为可靠图标来源 4. 保持对常规应用的向后兼容性 pms: BUG-315995 pms: BUG-281765
deepin pr auto review关键摘要:
是否建议立即修改: |
deepin-ci-robot
added a commit
to linuxdeepin/dde-session-shell-snipe
that referenced
this pull request
May 20, 2025
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#9
18202781743
approved these changes
May 20, 2025
yixinshark
approved these changes
May 21, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes were necessary because:
feat: 改进玲珑应用的图标处理
修改原因: