Skip to content

Conversation

@fly602
Copy link
Contributor

@fly602 fly602 commented Apr 2, 2025

remove startdde dependency

Log: remove startdde dependency
pms: TASK-374777

Summary by Sourcery

Chores:

  • Replace startdde configuration namespace with a more generic DDE daemon namespace

remove startdde dependency

Log: remove startdde dependency
pms: TASK-374777
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 2, 2025

Reviewer's Guide by Sourcery

This pull request removes the startdde dependency and updates the DConfig namespace to dde-daemon. The changes involve modifying the dde-blackwidget source code and the Debian packaging files.

Updated class diagram for Window class

classDiagram
  class Window {
    -m_gravityRotateBlackEnabled : bool
    +Window(QWidget *parent)
  }
  note for Window "DConfig namespace updated from org.deepin.startdde to org.deepin.dde.daemon"
Loading

File-Level Changes

Change Details Files
Updated the DConfig namespace to reflect the move from startdde to dde-daemon.
  • Changed the DConfig namespace from org.deepin.startdde to org.deepin.dde.daemon.
  • Updated the DConfig object creation to use the new namespace.
dde-blackwidget/src/window.cpp
Removed the startdde dependency.
  • Removed the startdde dependency in debian/control.
  • Updated the changelog to reflect the removal of the startdde dependency.
debian/changelog
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 配置文件路径更改

    • window.cpp文件中,配置文件路径从org.deepin.startdde更改为org.deepin.dde.daemon。需要确认这个更改是否与项目的其他部分保持一致,并且是否有相应的配置文件更新。
  2. 资源释放

    • window.cpp文件中,dsgConfig对象在使用后立即被删除。这是一个好的做法,可以避免内存泄漏。但是,如果dsgConfig的创建失败,应该添加错误处理逻辑,以防止程序在未初始化的指针上调用deleteLater()
  3. 依赖项更新

    • debian/control文件中,dde-daemon的版本从5.13.27更新到6.1.26。需要确认这个版本更新是否与项目的其他部分兼容,并且是否有相应的代码更新来支持新版本的dde-daemon
  4. changelog更新

    • debian/changelog文件中,添加了一个新的changelog条目,说明移除了startdde的依赖。需要确认这个更改是否已经过充分测试,并且不会对其他依赖项或功能产生负面影响。
  5. 翻译问题

    • debian/changelog文件中,提到了Low battery window not translated的修复。需要确认这个修复是否已经完成,并且相关的翻译文件是否已经更新。
  6. 依赖项移除

    • debian/control文件中,移除了startdde的依赖。需要确认这个移除是否已经过充分讨论,并且不会对项目的其他部分产生负面影响。
  7. 版本号一致性

    • debian/changelog文件中,版本号从6.0.26更新到6.0.27。需要确认这个版本号更新是否与项目的其他部分保持一致,并且是否有相应的代码更新来支持新版本。

总体来说,代码的更改看起来是合理的,但是需要确保所有的更改都已经过充分测试,并且与项目的其他部分保持一致。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fly602 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's good to see the configuration namespace being updated to reflect the move away from startdde.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

TAG Bot

TAG: 6.0.27
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants