Skip to content

Conversation

@robertkill
Copy link
Contributor

@robertkill robertkill commented May 29, 2025

Center text horizontally in RecognizeDialog paint event

Adjust the x-coordinate calculation in RecognizeDialog::paintEvent to properly center the text within the dialog. The previous calculation did not account for the full width of the text, resulting in misalignment. This change ensures the text is centered correctly.

pms: BUG-307573

Summary by Sourcery

Bug Fixes:

  • Correct x-coordinate computation in RecognizeDialog::paintEvent to center text horizontally and prevent truncation.

Center text horizontally in RecognizeDialog paint event

Adjust the x-coordinate calculation in `RecognizeDialog::paintEvent` to properly center the text within the dialog. The previous calculation did not account for the full width of the text, resulting in misalignment. This change ensures the text is centered correctly.

pms: BUG-307573
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中的 fm.horizontalAdvance(m_text) 返回的是文本的宽度,减去一半后作为 addText 的 x 坐标,确保文本在矩形中居中。
  • 代码中的 QColor brushCorlor 可能是拼写错误,应该是 QColor brushColor

是否建议立即修改:

  • 是,建议立即修改拼写错误,以避免潜在的混淆和潜在的错误。

@sourcery-ai
Copy link

sourcery-ai bot commented May 29, 2025

Reviewer's Guide

This PR fixes the horizontal centering logic in RecognizeDialog by updating the x‐coordinate calculation in the paintEvent, ensuring text is centered based on its full width rather than misaligned by half its width.

Sequence Diagram: Text Centering Logic in RecognizeDialog::paintEvent

sequenceDiagram
    participant PE as "RecognizeDialog::paintEvent"
    participant FM as "QFontMetrics"
    participant PP as "QPainterPath"

    PE->>FM: horizontalAdvance(m_text)
    activate FM
    FM-->>PE: textWidth
    deactivate FM

    alt Old X-Coordinate Calculation
        PE->>PP: addText( (m_rect.width() - textWidth / 2.0), y_coord, font, m_text )
        activate PP
        PP-->>PE: 
        deactivate PP
    else New X-Coordinate Calculation (Centered)
        PE->>PP: addText( (m_rect.width() - textWidth) / 2.0, y_coord, font, m_text )
        activate PP
        PP-->>PE: 
        deactivate PP
    end
Loading

Class Diagram: Update to RecognizeDialog

classDiagram
  class RecognizeDialog {
    +paintEvent(QPaintEvent *event) void
  }
Loading

File-Level Changes

Change Details Files
Correct horizontal centering calculation in RecognizeDialog::paintEvent
  • Replaced x-coordinate expression in path.addText call to subtract full text width before dividing by two
  • Retained existing vertical offset formula unchanged
dde-touchscreen-dialog/src/recognizedialog.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robertkill - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robertkill, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robertkill robertkill merged commit 1b99634 into linuxdeepin:master May 29, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants