-
Notifications
You must be signed in to change notification settings - Fork 59
refactor: move security flags to debian/rules #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Removed hardcoded security compilation flags from CMakeLists.txt 2. Added standardized Debian hardening flags in debian/rules 3. Flags now follow Debian packaging best practices 4. Includes additional security measures like RELRO and immediate binding 5. Maintains same security level while being more maintainable refactor: 将安全编译参数移至 debian/rules 1. 从 CMakeLists.txt 中移除硬编码的安全编译参数 2. 在 debian/rules 中添加标准化的 Debian 加固标志 3. 标志现在遵循 Debian 打包最佳实践 4. 包含额外的安全措施如 RELRO 和立即绑定 5. 在保持相同安全级别的同时提高可维护性
Reviewer's GuideThis commit refactors the build system by removing embedded security flags from CMakeLists.txt and centralizing them in debian/rules, applying standardized Debian hardening flags (including RELRO and immediate binding) to preserve the existing security posture while improving maintainability and aligning with Debian packaging best practices. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review代码审查意见如下: CMakeLists.txt 文件修改建议
代码质量
debian/rules 文件修改建议
代码质量
代码性能
代码安全
总的来说,这些修改和改进有助于提高代码的质量、性能和安全性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
refactor: 将安全编译参数移至 debian/rules
Summary by Sourcery
Centralize compilation hardening flags in the Debian packaging rules and remove them from CMakeLists to follow Debian best practices and improve maintainability.
Enhancements:
Build: