-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add plugin update to tray whitelist #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add plugin-update::update-state-key to the tray whitelist configuration This enables the plugin update indicator to be displayed in the system tray The change allows users to see update notifications directly from the dock tray feat: 添加插件更新到托盘白名单 在托盘白名单配置中添加 plugin-update::update-state-key 这使得插件更新指示器可以在系统托盘中显示 该更改允许用户直接从dock托盘中看到更新通知 PMS: TASK-383451
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the dock tray configuration by adding the plugin update state key to its whitelist, allowing the plugin update indicator to be shown in the system tray. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider alphabetically sorting the whitelist entries in org.deepin.ds.dock.tray.json to maintain consistency and simplify future reviews.
- Instead of hardcoding "plugin-update::update-state-key" here, consider centralizing such keys in a shared constant or config to reduce duplication and typos.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider alphabetically sorting the whitelist entries in org.deepin.ds.dock.tray.json to maintain consistency and simplify future reviews.
- Instead of hardcoding "plugin-update::update-state-key" here, consider centralizing such keys in a shared constant or config to reduce duplication and typos.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review我来对这个 git diff 进行代码审查:
改进建议:
总的来说,这是一个清晰、规范的配置修改,没有发现明显问题。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: behind) |
Add plugin-update::update-state-key to the tray whitelist configuration This enables the plugin update indicator to be displayed in the system tray
The change allows users to see update notifications directly from the dock tray
feat: 添加插件更新到托盘白名单
在托盘白名单配置中添加 plugin-update::update-state-key
这使得插件更新指示器可以在系统托盘中显示
该更改允许用户直接从dock托盘中看到更新通知
PMS: TASK-383451
Summary by Sourcery
New Features: