Skip to content

Conversation

@wjyrich
Copy link
Contributor

@wjyrich wjyrich commented Nov 7, 2025

Add plugin-update::update-state-key to the tray whitelist configuration This enables the plugin update indicator to be displayed in the system tray
The change allows users to see update notifications directly from the dock tray

feat: 添加插件更新到托盘白名单

在托盘白名单配置中添加 plugin-update::update-state-key
这使得插件更新指示器可以在系统托盘中显示
该更改允许用户直接从dock托盘中看到更新通知

PMS: TASK-383451

Summary by Sourcery

New Features:

  • Include plugin-update::update-state-key in the tray whitelist to display update notifications directly in the dock tray

Add plugin-update::update-state-key to the tray whitelist configuration
This enables the plugin update indicator to be displayed in the system
tray
The change allows users to see update notifications directly from the
dock tray

feat: 添加插件更新到托盘白名单

在托盘白名单配置中添加 plugin-update::update-state-key
这使得插件更新指示器可以在系统托盘中显示
该更改允许用户直接从dock托盘中看到更新通知

PMS: TASK-383451
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the dock tray configuration by adding the plugin update state key to its whitelist, allowing the plugin update indicator to be shown in the system tray.

File-Level Changes

Change Details Files
Extend tray whitelist for plugin update indicator
  • Added ‘plugin-update::update-state-key’ to tray whitelist configuration
panels/dock/dconfig/org.deepin.ds.dock.tray.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider alphabetically sorting the whitelist entries in org.deepin.ds.dock.tray.json to maintain consistency and simplify future reviews.
  • Instead of hardcoding "plugin-update::update-state-key" here, consider centralizing such keys in a shared constant or config to reduce duplication and typos.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider alphabetically sorting the whitelist entries in org.deepin.ds.dock.tray.json to maintain consistency and simplify future reviews.
- Instead of hardcoding "plugin-update::update-state-key" here, consider centralizing such keys in a shared constant or config to reduce duplication and typos.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个 git diff 进行代码审查:

  1. 语法逻辑:
  • 修改的是一个 JSON 配置文件,语法上完全正确
  • 在数组中添加了一个新的字符串元素 "plugin-update::update-state-key",格式与现有元素保持一致
  • 逗号的使用符合 JSON 语法规范
  1. 代码质量:
  • 代码风格统一:新增的配置项格式与现有配置项保持一致,都使用了 "namespace::key" 的格式
  • 命名规范:plugin-update::update-state-key 命名清晰,使用连字符分隔,符合常规命名规范
  • 位置合理:新配置项被添加在数组中间位置,按字母顺序来看位置合适(在 "network" 之前)
  1. 代码性能:
  • 作为配置文件的修改,不会直接影响运行时性能
  • 数组中增加一个元素对性能影响微乎其微
  1. 代码安全:
  • 配置项名称不包含敏感信息
  • 没有引入任何安全风险
  • 修改内容与系统更新相关,属于正常功能配置

改进建议:

  1. 建议在提交信息中说明添加这个配置项的具体用途
  2. 可以考虑在配置文件中添加注释说明这个配置项的作用(如果该配置文件格式支持注释)
  3. 建议确保相关代码已经实现了对这个新配置项的处理逻辑

总的来说,这是一个清晰、规范的配置修改,没有发现明显问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
Copy link
Contributor Author

wjyrich commented Nov 12, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 12, 2025

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit 08385dc into linuxdeepin:master Nov 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants