Skip to content

Conversation

@wjyrich
Copy link
Contributor

@wjyrich wjyrich commented Nov 27, 2025

Changed the border width of the app item from 2px to 1px to create a more subtle and visually appealing appearance. The previous 2px border was too prominent and created visual clutter in the task manager interface. This adjustment improves the overall aesthetic by making the border less obtrusive while still maintaining the visual separation between app items.

Influence:

  1. Verify app items in the dock display with thinner borders
  2. Check that the border is still visible but less prominent
  3. Test hover and active states to ensure border visibility is appropriate
  4. Verify the change doesn't affect the layout or spacing of app items
  5. Test with different themes to ensure consistent appearance

fix: 减小应用项边框宽度

将应用项的边框宽度从2像素改为1像素,以创建更微妙和视觉上更吸引人的外观。
之前的2像素边框过于突出,在任务管理器界面中造成了视觉混乱。此调整通过使
边框不那么突兀来改善整体美观性,同时仍保持应用项之间的视觉分隔。

Influence:

  1. 验证坞站中的应用项是否显示更细的边框
  2. 检查边框仍然可见但不太突出
  3. 测试悬停和活动状态,确保边框可见性适当
  4. 验证更改不会影响应用项的布局或间距
  5. 使用不同主题测试以确保外观一致

Summary by Sourcery

Enhancements:

  • Adjust app item border width from 2px to 1px in the dock task manager for a subtler visual appearance.

Changed the border width of the app item from 2px to 1px to create a
more subtle and visually appealing appearance. The previous 2px border
was too prominent and created visual clutter in the task manager
interface. This adjustment improves the overall aesthetic by making
the border less obtrusive while still maintaining the visual separation
between app items.

Influence:
1. Verify app items in the dock display with thinner borders
2. Check that the border is still visible but less prominent
3. Test hover and active states to ensure border visibility is
appropriate
4. Verify the change doesn't affect the layout or spacing of app items
5. Test with different themes to ensure consistent appearance

fix: 减小应用项边框宽度

将应用项的边框宽度从2像素改为1像素,以创建更微妙和视觉上更吸引人的外观。
之前的2像素边框过于突出,在任务管理器界面中造成了视觉混乱。此调整通过使
边框不那么突兀来改善整体美观性,同时仍保持应用项之间的视觉分隔。

Influence:
1. 验证坞站中的应用项是否显示更细的边框
2. 检查边框仍然可见但不太突出
3. 测试悬停和活动状态,确保边框可见性适当
4. 验证更改不会影响应用项的布局或间距
5. 使用不同主题测试以确保外观一致
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 27, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refines the visual style of dock task manager app items by reducing their outline thickness from 2px to 1px, making borders less visually dominant while preserving separation between items.

File-Level Changes

Change Details Files
Make the app item border in the dock task manager thinner by adjusting the QML rectangle border width from 2px to 1px.
  • Update the border width property on the app item’s outer rectangle from 2 to 1 to reduce visual prominence
  • Retain existing border color, transparency, and antialiasing settings so only the thickness changes
panels/dock/taskmanager/package/AppItemWithTitle.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider binding the border width to a theme or shared style constant instead of a hard-coded 1, so that the appearance can be tuned consistently across different components and themes.
  • You may want to verify that a fixed 1px border scales well on HiDPI displays; if not, using Qt.devicePixelRatio or a scalable unit could keep the border visually consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider binding the border width to a theme or shared style constant instead of a hard-coded `1`, so that the appearance can be tuned consistently across different components and themes.
- You may want to verify that a fixed 1px border scales well on HiDPI displays; if not, using `Qt.devicePixelRatio` or a scalable unit could keep the border visually consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这段代码变更进行审查:

  1. 语法逻辑:

    • 代码语法正确,这是一个简单的属性值修改,将边框宽度从2改为1
    • 修改不会影响代码的语法正确性和逻辑结构
  2. 代码质量:

    • 修改是合理的,将边框宽度从2px减小到1px可以让界面看起来更加精致
    • 建议考虑将这个数值抽取为一个常量或属性,方便统一管理和修改
    • 例如可以添加:property int borderWidth: 1
  3. 代码性能:

    • 这个修改对性能影响微乎其微
    • 较小的边框宽度实际上可能会略微提升渲染性能,因为需要绘制的像素更少
  4. 代码安全:

    • 这个修改不涉及任何安全问题
    • 纯UI层面的改动,不会影响应用程序的安全性

建议:

  1. 考虑将边框宽度值提取为一个属性,便于维护和统一管理:
Item {
    property int borderWidth: 1
    
    Rectangle {
        border.width: borderWidth
        // ...
    }
}
  1. 如果这个边框样式在其他地方也会使用,建议将其抽取为一个独立的组件,提高代码复用性。

总的来说,这是一个简单合理的UI优化修改,可以让界面看起来更加精致。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
Copy link
Contributor Author

wjyrich commented Nov 27, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 27, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit e5a1006 into linuxdeepin:master Nov 27, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants