Skip to content

Conversation

@wyu71
Copy link
Contributor

@wyu71 wyu71 commented Jan 6, 2026

Added clip property to ListView to ensure notifications stay within visible bounds during Tab navigation.

Log: clip ListView content to prevent overflow in NotifyView
pms: BUG-345543

Summary by Sourcery

Bug Fixes:

  • Prevent notification items in NotifyView from overflowing outside the ListView area during tab-based navigation

Added clip property to ListView to ensure notifications stay within visible bounds during Tab navigation.

Log: clip ListView content to prevent overflow in NotifyView
pms: BUG-345543
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds clipping to the notification ListView in NotifyView to prevent its content from visually overflowing the view bounds during navigation between tabs.

File-Level Changes

Change Details Files
Ensure notification list content is clipped to the visible bounds of NotifyView to avoid overflow during tab navigation.
  • Enable clipping on the ListView used as the contentItem of NotifyView so that items are not rendered outside its rectangular area.
  • Keep existing ListView behaviors such as spacing, snap mode, and key navigation unchanged.
panels/notification/center/NotifyView.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个diff进行审查:

  1. 修改内容分析:

    • 在ListView中添加了clip: true属性
    • 这是一个简单的修改,目的是让ListView的内容被裁剪在其边界内
  2. 代码质量分析:

    • 修改位置合适,与其他属性格式保持一致
    • 代码风格符合QML规范
    • 修改简单直接,没有引入复杂性
  3. 功能影响分析:

    • clip: true将确保ListView的内容不会超出其边界显示
    • 这可以防止通知项在滚动时显示在ListView外部
    • 对于通知中心这样的场景,这是一个合理的设置
  4. 性能考虑:

    • 启用clip可能会带来轻微的性能开销,因为需要进行额外的裁剪计算
    • 但在这个场景下,性能影响应该是可以接受的,因为:
      • 通知中心通常不会同时显示大量通知
      • 现代图形硬件能够很好地处理这种裁剪操作
  5. 建议和改进:

    • 这个修改是合适的,建议保留
    • 如果未来发现性能问题,可以考虑:
      • 限制同时显示的通知数量
      • 实现虚拟滚动(如果ListView没有自动启用)
    • 建议添加注释说明为什么需要clip,例如:
      clip: true // 确保通知项不会显示在ListView边界外

总结:
这是一个合理的修改,能够改善通知中心的视觉表现,虽然可能有轻微的性能开销,但在实际使用中应该是可以接受的。建议保留这个修改,并考虑添加注释说明原因。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71
Copy link
Contributor Author

wyu71 commented Jan 6, 2026

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jan 6, 2026

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit ed1f8dc into linuxdeepin:master Jan 6, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants