Skip to content

Conversation

@justforlxz
Copy link
Member

remove Q_DECL_EXPORT, maybe Qt change default.

Log:

remove Q_DECL_EXPORT, maybe Qt change default.

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 类定义中移除了 Q_DECL_EXPORT 宏,需要确认这是否是有意为之,因为这可能会影响动态链接库的导出行为。

是否建议立即修改:

  • 是,如果移除 Q_DECL_EXPORT 是无意的,应该立即恢复,以避免潜在的链接问题。如果是有意为之,应该确保相关的文档和构建配置都已更新以反映这一变化。

@justforlxz
Copy link
Member Author

https://gitlab.archlinux.org/archlinux/packaging/packages/qt6-base/-/blob/main/PKGBUILD?ref_type=heads#L117

archlinux enabled qt config -DFEATURE_no_direct_extern_access=ON, it will define QT_USE_PROTECTED_VISIBILITY macro in qconfig.h

qcompilerdetection.h will define Q_DECL_EXPORT protected, symbol will hidden.

#    ifdef QT_USE_PROTECTED_VISIBILITY
#      define Q_DECL_EXPORT     __attribute__((visibility("protected")))
#    else
#      define Q_DECL_EXPORT     __attribute__((visibility("default")))
#    endif

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit 74e2b56 into linuxdeepin:master Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants