Skip to content

Conversation

@justforlxz
Copy link
Member

as title

Log:

user will be activated in loginctl

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Display.cpp中,switchToUser函数中添加了对用户名为"dde"的特殊处理,但没有考虑到其他用户名的情况。
  • Greeter.cpponHelperFinished函数中,当m_singleMode为真时,会根据m_userActivated的值来决定是否添加--lockscreen参数,但这个逻辑可能会在非单用户模式下被调用。
  • SingleWaylandHelper类中移除了对标准输出和标准错误的处理,这可能会影响调试和错误信息的记录。
  • SingleWaylandHelper类中移除了对进程退出码和重启次数的处理,这可能会影响进程的稳定性和错误处理。

是否建议立即修改:

  • 应该立即修复switchToUser函数中对用户名为"dde"的特殊处理,确保它适用于所有用户名。
  • 应该检查Greeter.cpponHelperFinished函数的逻辑,确保它只在单用户模式下被调用,并且正确处理了m_userActivated的值。
  • 应该恢复对SingleWaylandHelper类中标准输出和标准错误的处理,以便于调试和错误信息的记录。
  • 应该恢复对SingleWaylandHelper类中进程退出码和重启次数的处理,以确保进程的稳定性和错误处理。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, justforlxz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Groveer pushed a commit to linuxdeepin/treeland.private that referenced this pull request Nov 28, 2024
need DDM switch to greeter and state sync

linuxdeepin/ddm#22

Log:
@justforlxz justforlxz merged commit bedba95 into linuxdeepin:master Nov 28, 2024
9 checks passed
SunRain pushed a commit to SunRain/DeckShell that referenced this pull request Sep 15, 2025
need DDM switch to greeter and state sync

linuxdeepin/ddm#22

Log:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants