-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Create a new seatd service for DDE #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIsolate DDE’s seat management by introducing a dedicated seatd-dde.service with enhanced security, updating CMake to install it, removing the global seatd override, and modifying ddm.service to depend on the new seatd-dde.service. Flow diagram for installation and dependency changesflowchart TD
A[Install seatd-dde.service] --> B[Remove override for seatd.service]
B --> C[Modify ddm.service to depend on seatd-dde.service]
C --> D[DDE uses dedicated seatd-dde.service]
D --> E[Other apps use system seatd.service]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Introduce `seatd-dde.service` to avoid conflicts with the system's existing `seatd.service`. This allows Deepin Desktop Environment (DDE) to manage its seat without affecting other applications relying on `seatd`. 2. Remove the override for the global `seatd.service`. This prevents DDE's configuration from unintentionally altering the behavior of the system's seatd instance. 3. Modify `ddm.service` to depend on `seatd-dde.service` instead of `seatd.service`. This ensures that DDE's display manager (ddm) utilizes the dedicated seatd service for DDE. 4. The `seatd-dde.service` is configured to run as the `dde` user and group and sets `SEATD_VTBOUND=0`. It includes filesystem lockdown, privilege restriction, and network isolation settings for enhanced security. 5. The changes ensure that DDE's seat management operates independently, preventing potential interference with other system components. feat: 为 DDE 创建新的 seatd 服务 1. 引入 `seatd-dde.service` 以避免与系统现有的 `seatd.service` 冲突。这 允许 Deepin 桌面环境 (DDE) 管理其会话,而不会影响依赖 `seatd` 的其他应用 程序。 2. 移除对全局 `seatd.service` 的覆盖。这可以防止 DDE 的配置意外更改系统 `seatd` 实例的行为。 3. 修改 `ddm.service` 以依赖 `seatd-dde.service` 而不是 `seatd.service`。这确保了 DDE 的显示管理器 (ddm) 使用专用于 DDE 的 seatd 服务。 4. `seatd-dde.service` 配置为以 `dde` 用户和组运行,并设置 `SEATD_VTBOUND=0`。它包括文件系统锁定、权限限制和网络隔离设置,以增强安 全性。 5. 这些更改确保 DDE 的会话管理独立运行,防止与其他系统组件的潜在干扰。
deepin pr auto review代码审查意见:
总体来说,这个提交的改动看起来是有意义的,但是需要确保所有的配置都是正确的,并且不会对系统的其他部分产生负面影响。同时,建议进行全面的测试,以确保这些改动不会引入新的问题。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justforlxz, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
seatd-dde.serviceto avoid conflicts with the system's existingseatd.service. This allows Deepin Desktop Environment (DDE) to manage its seat without affecting other applications relying onseatd.seatd.service. This prevents DDE's configuration from unintentionally altering the behavior of the system's seatd instance.ddm.serviceto depend onseatd-dde.serviceinstead ofseatd.service. This ensures that DDE's display manager (ddm) utilizes the dedicated seatd service for DDE.seatd-dde.serviceis configured to run as theddeuser and group and setsSEATD_VTBOUND=0. It includes filesystem lockdown, privilege restriction, and network isolation settings for enhanced security.feat: 为 DDE 创建新的 seatd 服务
seatd-dde.service以避免与系统现有的seatd.service冲突。这 允许 Deepin 桌面环境 (DDE) 管理其会话,而不会影响依赖seatd的其他应用程序。
seatd.service的覆盖。这可以防止 DDE 的配置意外更改系统seatd实例的行为。ddm.service以依赖seatd-dde.service而不是seatd.service。这确保了 DDE 的显示管理器 (ddm) 使用专用于 DDE 的 seatd 服务。seatd-dde.service配置为以dde用户和组运行,并设置SEATD_VTBOUND=0。它包括文件系统锁定、权限限制和网络隔离设置,以增强安全性。
Summary by Sourcery
Isolate DDE’s seat management by introducing and installing a dedicated seatd-dde.service, updating ddm.service to use it, removing the global seatd override, and applying security hardening settings to the new unit.
New Features:
Enhancements:
Build: