Skip to content

Conversation

@wineee
Copy link
Member

@wineee wineee commented Aug 21, 2025

log: Support VT switching

Summary by Sourcery

Update Debian package version to 0.1.12 and document support for virtual terminal switching.

New Features:

  • Support VT switching

Chores:

  • Bump Debian package version to 0.1.12 in changelog

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

TAG Bot

TAG: 0.2.0
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Debian packaging to version 0.1.12 and records the "Support VT switching" change in the changelog.

File-Level Changes

Change Details Files
Bump Debian package version and update changelog
  • Increment version to 0.1.12
  • Add entry noting VT switching support
  • Update timestamp and maintainer signature
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wineee wineee marked this pull request as draft August 21, 2025 07:23
@wineee wineee marked this pull request as ready for review August 29, 2025 02:21
log: Support VT switching
@deepin-ci-robot
Copy link

deepin pr auto review

根据提供的git diff,我来分析一下这些变更并提出改进建议:

1. 版本号变更分析

  • 从0.2.2降级到0.2.0
  • 建议确认这是否为故意回退,如果是,应在changelog中明确说明原因
  • 如果是版本管理错误,建议立即恢复正确的版本号

2. 依赖项变更分析

find_package(TreelandProtocols 0.5.0 REQUIRED)
  • 添加了版本号约束,这是一个好的改进
  • 建议确认0.5.0是否为最低兼容版本
  • 考虑添加版本范围说明,如"0.5.0"到"0.6.0"之间都兼容

3. CMake配置改进分析

  • 添加了版本文件配置:
write_basic_package_version_file(
    "${CMAKE_CURRENT_BINARY_DIR}/data/DDMConfigVersion.cmake"
    VERSION ${DDM_VERSION_STRING}
    COMPATIBILITY SameMajorVersion
)
  • 这是一个很好的改进,提供了更好的版本兼容性控制
  • 建议在文档中说明版本兼容策略

4. 安装路径改进

INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/DDM
  • 添加了缺失的斜杠,修复了路径问题
  • 建议保持一致的路径分隔符风格

5. 版本信息暴露

在DDMConfig.cmake.in中添加了版本信息:

set(DDM_VERSION_MAJOR @DDM_VERSION_MAJOR@)
set(DDM_VERSION_MINOR @DDM_VERSION_MINOR@)
set(DDM_VERSION_PATCH @DDM_VERSION_PATCH@)
set(DDM_VERSION @DDM_VERSION_STRING@)
  • 这是一个好的改进,提高了版本信息的透明度
  • 建议考虑添加版本检查宏,便于依赖此包的项目进行版本检查

6. 总体建议

  1. 版本管理:

    • 确保版本号变更符合语义化版本规范
    • 建议使用自动化工具管理版本号,避免手动错误
  2. 依赖管理:

    • 为所有外部依赖添加最低版本要求
    • 考虑使用版本范围而非固定版本号
  3. 文档完善:

    • 更新CMake配置相关文档
    • 说明版本兼容性策略
  4. 持续集成:

    • 添加CMake版本检查
    • 确保CI环境中使用正确的CMake版本
  5. 安全考虑:

    • 确保所有安装路径使用CMake提供的标准变量
    • 避免硬编码路径

这些变更整体上是积极的,特别是版本信息暴露和依赖版本约束的添加。建议在后续开发中继续保持这些良好的实践。

@wineee wineee changed the title chore(debian): update version to 0.1.12 chore(debian): update version to 0.2.0 Aug 29, 2025
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit b0bf6e9 into linuxdeepin:master Aug 29, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants