Skip to content

Conversation

@misaka18931
Copy link
Contributor

@misaka18931 misaka18931 commented Sep 4, 2025

Fixed a list of things below (for building on Nix):

  • required input treeland-protocols in nix/default.nix was not passed when calling the ddm package.
  • dependency wayland was not declared.
  • wayland-scanner is used in building process, but was never declared in nativeBuildInputs.
  • flake.lock depending on multiple nixpkgs, flake-utils and nix-filters instances.

Summary by Sourcery

Fix Nix build failures and versioning by declaring missing package inputs, correcting the ddm version, and consolidating flake dependencies

Bug Fixes:

  • Add treeland-protocols input to flake.nix and pass it to the ddm package
  • Declare wayland and wayland-scanner in default.nix to satisfy build requirements
  • Correct ddm version from 0.2.2 to 0.2.0

Build:

  • Unify flake.lock to use single instances of nixpkgs, flake-utils, and nix-filter

@deepin-ci-robot
Copy link

Hi @misaka18931. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

Hi @misaka18931. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR resolves Nix build failures by injecting the missing treeland-protocols flake, declaring undeclared Wayland dependencies, correcting the package version, and regenerating the lockfile for consistent flake inputs.

File-Level Changes

Change Details Files
Add treeland-protocols as a flake input and pass it into the ddm derivation
  • Declare treeland-protocols in the flake inputs with URL and follow attributes
  • Include treeland-protocols in the outputs parameter list
  • Pass treeland-protocols.packages.${system}.default into callPackage
flake.nix
Declare missing Wayland build dependencies
  • Add wayland to function arguments and buildInputs
  • Add wayland-scanner to nativeBuildInputs
nix/default.nix
Fix incorrect package version
  • Change version from 0.2.2 to 0.2.0
nix/default.nix
Regenerate lockfile to unify flake dependencies
  • Update flake.lock to include the new treeland-protocols input
  • Ensure a single instance of nixpkgs, flake-utils, and nix-filter is locked
flake.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@misaka18931
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

deepin-bot bot added a commit to linuxdeepin/cla that referenced this pull request Sep 4, 2025
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: misaka18931, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wineee wineee merged commit 3b38aef into linuxdeepin:master Sep 10, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants