-
Notifications
You must be signed in to change notification settings - Fork 16
chore: update license configuration to REUSE specification #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit transitions the project's license management from the deprecated .reuse/dep5 format to the modern REUSE.toml configuration. The changes include: 1. Removed old .reuse/dep5 file and multiple license text files (Apache- 2.0, GPL-3.0-only, LGPL-3.0-only) 2. Renamed GPL-2.0-only.txt to GPL-2.0-or-later.txt to reflect actual license usage 3. Added comprehensive REUSE.toml file with detailed SPDX annotations for different file types 4. Updated README.md to reference REUSE file instead of direct LICENSE file 5. Modified debian/copyright to use GPL-2+ instead of LGPL-3+ and added proper file-specific copyright attributions 6. Updated SPDX license identifiers in several source files from complex multi-license expressions to GPL-2.0-or-later The migration ensures better compliance with REUSE specification and simplifies license management across the project. Influence: 1. Verify all source files contain proper SPDX headers 2. Test build process to ensure license changes don't affect compilation 3. Check that debian packaging still works correctly with updated copyright file 4. Validate that the new REUSE.toml configuration covers all file types appropriately chore: 更新许可证配置以符合 REUSE 规范 本次提交将项目的许可证管理从过时的 .reuse/dep5 格式迁移到现代的 REUSE.toml 配置。变更包括: 1. 移除了旧的 .reuse/dep5 文件和多个许可证文本文件(Apache-2.0、GPL-3.0- only、LGPL-3.0-only) 2. 将 GPL-2.0-only.txt 重命名为 GPL-2.0-or-later.txt 以反映实际许可证使 用情况 3. 添加了包含详细 SPDX 注解的 REUSE.toml 文件,涵盖不同文件类型 4. 更新了 README.md 以引用 REUSE 文件而不是直接的 LICENSE 文件 5. 修改了 debian/copyright 使用 GPL-2+ 替代 LGPL-3+ 并添加了适当的文件特 定版权归属 6. 更新了多个源文件中的 SPDX 许可证标识符,从复杂的多许可证表达式改为 GPL-2.0-or-later 此次迁移确保了更好地符合 REUSE 规范,并简化了整个项目的许可证管理。 Influence: 1. 验证所有源文件包含正确的 SPDX 头信息 2. 测试构建过程以确保许可证更改不影响编译 3. 检查 Debian 打包在更新版权文件后仍能正常工作 4. 验证新的 REUSE.toml 配置是否适当覆盖所有文件类型
Reviewer's GuideThis PR migrates project licensing from legacy DEP5 and individual license texts to a centralized REUSE.toml configuration, renames the GPL-2.0-only text file to reflect or-later usage, updates SPDX headers in source files to a single GPL-2.0-or-later identifier, and adjusts documentation and Debian packaging to align with the REUSE specification. Entity relationship diagram for license annotation coverage in REUSE.tomlerDiagram
REUSE_TOML ||--o| ANNOTATION : contains
ANNOTATION ||--|{ FILE : covers
REUSE_TOML {
string version
string SPDX-PackageName
string SPDX-PackageDownloadLocation
}
ANNOTATION {
string path
string precedence
string SPDX-FileCopyrightText
string SPDX-License-Identifier
}
FILE {
string filename
string filetype
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review根据提供的git diff,这是一个关于许可证变更的提交。主要变化包括:
改进建议:
总体而言,这次许可证变更简化了项目的许可证管理,采用REUSE标准是良好的做法。但需要注意保留历史许可证信息,确保项目的完整性和可追溯性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- It looks like debian/copyright.bak was accidentally committed—please remove that backup file from the PR.
- The final REUSE.toml annotation block lists every source file individually—consider using broader glob patterns to keep the list maintainable.
- Make sure any Debian packaging scripts or lintian configuration no longer reference the old dep5 format and are updated to use REUSE.toml.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like debian/copyright.bak was accidentally committed—please remove that backup file from the PR.
- The final REUSE.toml annotation block lists every source file individually—consider using broader glob patterns to keep the list maintainable.
- Make sure any Debian packaging scripts or lintian configuration no longer reference the old dep5 format and are updated to use REUSE.toml.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Groveer, wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This commit transitions the project's license management from the deprecated .reuse/dep5 format to the modern REUSE.toml configuration. The changes include:
The migration ensures better compliance with REUSE specification and simplifies license management across the project.
Influence:
chore: 更新许可证配置以符合 REUSE 规范
本次提交将项目的许可证管理从过时的 .reuse/dep5 格式迁移到现代的
REUSE.toml 配置。变更包括:
此次迁移确保了更好地符合 REUSE 规范,并简化了整个项目的许可证管理。
Influence:
Summary by Sourcery
Update license management to comply with the REUSE specification by migrating from the deprecated .reuse/dep5 format to a unified REUSE.toml configuration, removing old license files, and updating related references.
Enhancements:
Documentation: