Skip to content

fix: fix dde-session not started after ddm restart & crash recovery #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zccrs merged 1 commit into from
Dec 16, 2025
Merged

fix: fix dde-session not started after ddm restart & crash recovery #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/daemon/Display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ namespace DDM {
SocketWriter writer(socket);
for (Auth *auth : loginedSession()) {
if (auth->isActive())
writer << quint32(DaemonMessages::UserLoggedIn) << auth->user();
writer << quint32(DaemonMessages::UserLoggedIn) << auth->user() << auth->xdgSessionId();
}
}

Expand Down
2 changes: 0 additions & 2 deletions src/daemon/TreelandConnector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ bool TreelandConnector::isConnected() {
}

void TreelandConnector::setPrivateObject(struct treeland_ddm *ddm) {
if (m_ddm)
Copy link

@sourcery-ai sourcery-ai bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Clarify ownership/lifetime of m_ddm now that the previous instance is no longer destroyed.

By removing treeland_ddm_destroy(m_ddm), m_ddm’s ownership semantics change. If setPrivateObject is called more than once, previous instances will not be destroyed here, which can cause leaks or multiple live instances unless another owner handles cleanup. Please confirm whether ownership is intentionally transferred elsewhere and that callers are not depending on setPrivateObject to free the old object.

treeland_ddm_destroy(m_ddm);
m_ddm = ddm;
}

Expand Down