refactor: Refactor PAM authenticate module #55
Merged
Annotations
10 warnings
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L65
Parameter 'secret_ptr' can be declared as pointer to const. However it seems that 'converse' is a callback function, if 'secret_ptr' is declared with const you might also need to cast function pointer(s).
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L18
C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L62
Class 'PamPrivate' has a constructor with 1 argument that is not explicit. Such, so called "Converting constructors", should in general be explicit for type safety reasons as that prevents unintended implicit conversions.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L202
Include file: "Pam.moc" not found.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L10
Include file: <security/pam_appl.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L8
Include file: <QDebug> not found. Please note: Cppcheck does not need standard library headers to get proper results.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/Pam.cpp#L6
Include file: "VirtualTerminal.h" not found.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/HelperApp.cpp#L49
Include file: <signal.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/HelperApp.cpp#L25
Include file: "SafeDataStream.h" not found.
|
|
Run linuxdeepin/action-cppcheck@main:
src/helper/HelperApp.cpp#L23
Include file: "Configuration.h" not found.
|
Loading