Skip to content

Conversation

@ECQZXC
Copy link
Contributor

@ECQZXC ECQZXC commented Mar 11, 2025

未及时释放设备对象

pms: BUG-307657

Copy link
Contributor

@robertkill robertkill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证需要同步改下

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ErollThread::Stop函数中,m_camera.reset();的添加可能会影响m_camera对象的生命周期管理,需要确认是否有其他地方需要管理这个指针。
  • VerifyThread::Stop函数中,m_camera.reset();的添加同样需要确认是否有其他地方需要管理这个指针。

是否建议立即修改:

  • 是,需要确保m_camera.reset();的添加不会导致内存泄漏或指针悬挂问题,并且与整个程序的其他部分保持一致的生命周期管理策略。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ECQZXC, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ECQZXC
Copy link
Contributor Author

ECQZXC commented Mar 19, 2025

/forcemerge

@deepin-bot deepin-bot bot merged commit 952bf10 into linuxdeepin:master Mar 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants