fit: Camera occupied with no feedback

[robertkill]

QT6 multimedia mechanism changes result in unprocessed corresponding scenes

pms: BUG-309895

Summary by Sourcery

Update camera error handling in QT6 multimedia to correctly detect and report camera errors

Bug Fixes:

• Fix camera error detection mechanism to use QCamera::error() instead of checking error value directly

Enhancements:

• Improve error reporting for camera capture failures in QT6 multimedia framework

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 在ErollThread::captureError和VerifyThread::captureError函数中，错误检查逻辑从直接比较错误码改为检查相机错误状态，这是一个改进，因为它更准确地反映了相机是否处于错误状态。

是否建议立即修改:

• 否，提交的代码没有明显的语法或逻辑错误。
• 是，建议添加对m_camera指针是否为空的检查，以防止潜在的空指针解引用问题。
• 是，建议在qDebug输出中添加更多的上下文信息，比如当前线程的名称或动作ID，以便更容易调试。
• 是，建议在错误处理逻辑中添加重试机制或错误恢复逻辑，以增强系统的健壮性。
• 是，建议对FaceEnrollException进行更详细的定义和文档化，以便其他开发者理解异常的具体含义和使用场景。

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the camera error handling logic in ErollThread and VerifyThread to use the QCamera::error() method, which is the recommended approach in newer versions of Qt. This change addresses an issue where camera errors were not being properly detected due to changes in the Qt6 multimedia mechanism.

Sequence diagram for camera error handling in ErollThread

sequenceDiagram
  participant ErollThread
  participant QCamera

  ErollThread->>QCamera: m_camera->error()
  QCamera-->>ErollThread: Returns error code
  alt error != QCamera::NoError
    ErollThread->>ErollThread: qDebug() << "read camera fail:" << errorString
    ErollThread->>ErollThread: Q_EMIT processStatus(m_actionId, FaceEnrollException)
  end

Loading

Sequence diagram for camera error handling in VerifyThread

sequenceDiagram
  participant VerifyThread
  participant QCamera

  VerifyThread->>QCamera: m_camera->error()
  QCamera-->>VerifyThread: Returns error code
  alt error != QCamera::NoError
    VerifyThread->>VerifyThread: qDebug() << "read camera fail:" << errorString
    VerifyThread->>VerifyThread: Q_EMIT processStatus(m_actionId, FaceEnrollException)
  end

Loading

File-Level Changes

Change	Details	Files
Updated camera error checking to use the QCamera::error() method instead of relying on the deprecated integer error code.	Replaced the error code integer check with m_camera->error() != QCamera::NoError in ErollThread::captureError. Replaced the error code integer check with m_camera->error() != QCamera::NoError in VerifyThread::captureError.	workmodule.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @robertkill - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the error checking logic into a separate helper function to avoid duplication.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, mhduiy, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment