feat: add Debian packaging configuration #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mhduiy - I've reviewed your changes - here's some feedback:
- The new deepin-face.conf file is under
msic/instead ofdebian/; move it intodebian/and ensure it’s installed to/etc/ld.so.conf.d/with the proper multiarch path. - Populate
debian/deepin-face.installwith the actual library and config files (e.g. the .so files and the .conf) so they get included in the final package. - Replace the hardcoded
/usr/lib/autopaths with$(DEB_HOST_MULTIARCH)in both the .install and .conf to ensure compatibility with multiarch systems.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new deepin-face.conf file is under `msic/` instead of `debian/`; move it into `debian/` and ensure it’s installed to `/etc/ld.so.conf.d/` with the proper multiarch path.
- Populate `debian/deepin-face.install` with the actual library and config files (e.g. the .so files and the .conf) so they get included in the final package.
- Replace the hardcoded `/usr/lib/auto` paths with `$(DEB_HOST_MULTIARCH)` in both the .install and .conf to ensure compatibility with multiarch systems.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR adds full Debian packaging support for deepin-face by introducing installation scripts and configuration for library deployment and ldconfig management, bolstering build hardening via updated rules, and cleaning up redundant security flags from the project file. Flow diagram for library installation and ldconfig managementflowchart TD
A[Install package] --> B[Install library and config via deepin-face.install]
B --> C[Run postinst script]
C --> D[Execute ldconfig to update cache]
D --> E[Library available system-wide]
E --> F[Uninstall package]
F --> G[Run postrm script]
G --> H[Execute ldconfig to update cache]
H --> I[Library removed from system cache]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
approved these changes
Jul 9, 2025
1. Added deepin-face.install to install library configuration 2. Implemented postinst and postrm scripts for ldconfig management 3. Updated debian/rules with additional hardening flags 4. Removed redundant security flags from .pro file as they're now handled by Debian build 5. Added deepin-face.conf for library path configuration The changes improve package management by: - Properly handling library cache updates during install/remove - Centralizing security hardening in Debian build system - Simplifying project configuration by removing redundant flags - Ensuring consistent library path configuration feat: 添加 Debian 打包配置 1. 添加 deepin-face.install 用于安装库配置 2. 实现 postinst 和 postrm 脚本管理 ldconfig 3. 更新 debian/rules 添加额外的安全加固标志 4. 从 .pro 文件中移除冗余的安全标志，现在由 Debian 构建系统处理 5. 添加 deepin-face.conf 用于库路径配置 这些改进通过以下方式优化了包管理： - 正确管理安装/删除时的库缓存更新 - 在 Debian 构建系统中集中处理安全加固 - 通过移除冗余标志简化项目配置 - 确保一致的库路径配置
deepin pr auto review代码审查意见：
总体来说，代码的改动主要集中在文件路径的修改和安装脚本的增加，没有引入新的功能或逻辑。建议在合并这些改动之前，进行更全面的代码审查，以确保代码的质量和安全性。 |
BLumia
approved these changes
Jul 9, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes improve package management by:
feat: 添加 Debian 打包配置
这些改进通过以下方式优化了包管理：
Summary by Sourcery
Add Debian packaging support for deepin-face by introducing install rules and configuration, integrating security hardening in the build, and automating library cache and path management.
Enhancements:
Build:
Deployment: