fix: stop running not work

[deepin-mozart]

Log:
Bug: https://pms.uniontech.com/bug-view-314821.html Change-Id: Ie16bdc54fc2b5ed0abbe1fd1fd6a0877926f0c09

Summary by Sourcery

Bug Fixes:

• Ensure the target process is terminated by waiting for the kill command to complete.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS [deepin-mozart]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• defaultStopHandler 函数的参数名从 id 更改为 pid，需要确认这一更改是否与调用该函数的代码保持一致。
• 使用 QProcess 类来执行系统命令，增加了代码的健壮性和灵活性，但需要确保 pid 的来源是可信的，以防止潜在的命令注入攻击。

是否建议立即修改:

• 是，需要确保参数名的更改不会导致调用该函数的代码出现问题，并且需要验证 pid 的来源，以防止命令注入攻击。

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the default process stop handler to correctly terminate processes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Updated the default process stop handler to use a synchronous kill command.	Renamed the process ID parameter from 'id' to 'pid'. Changed the kill command execution from startDetached to a synchronous QProcess start and waitForFinished.	src/common/widget/appoutputpane.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

Overall Comments:

• Using waitForFinished() here might block the calling thread; consider if this could impact UI responsiveness if called from the main thread.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}