-
Notifications
You must be signed in to change notification settings - Fork 73
fix: crashed when open plugin detail page #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Log: Bug: https://pms.uniontech.com/bug-view-314807.html Change-Id: Ica69be9473023d282fb3e3ed5b09e2188d61d65e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryConditionalize OpenGL setting for ARM architecture based on Wayland usage to fix crash on plugin detail page. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-mozart - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider the rendering behavior on ARM systems that are not running Wayland, as this change restricts the OpenGLES setting specifically to Wayland environments.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Log:
Bug: https://pms.uniontech.com/bug-view-314807.html Change-Id: Ica69be9473023d282fb3e3ed5b09e2188d61d65e
Summary by Sourcery
Bug Fixes: