Skip to content

Conversation

@deepin-mozart
Copy link
Contributor

@deepin-mozart deepin-mozart commented May 9, 2025

disconnect to debugpy that has closed

Log:
Change-Id: Ia57b8165dd7d2547c5053aee1776be22d2ac8f9b

Summary by Sourcery

Bug Fixes:

  • Removed unnecessary disconnection call that may cause problems when closing a debug session

disconnect to debugpy that has closed

Log:
Change-Id: Ia57b8165dd7d2547c5053aee1776be22d2ac8f9b
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • shutdown函数中,注释掉的raw->disconnect({});行可能是有意为之,但需要确认是否有其他地方需要处理断开连接的逻辑。
  • raw.reset(nullptr);是正确的做法,用于释放raw指针,避免内存泄漏。

是否建议立即修改:

  • 否,当前的修改看起来是合理的,没有发现需要立即修改的问题。但是,需要确保注释掉的disconnect调用是有意为之,并且不会影响其他部分的逻辑。如果这个调用是必要的,应该将其取消注释。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-mozart - I've reviewed your changes - here's some feedback:

  • Consider adding a check for connection status to conditionally call raw->disconnect({}), ensuring graceful shutdown is attempted if debugpy is still responsive.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented May 9, 2025

Reviewer's Guide

This pull request modifies the DebugSession::shutdown method to prevent a potential block during Python debugging sessions by removing an explicit disconnect call. This addresses an issue where the debugger might hang if debugpy has already closed the connection.

File-Level Changes

Change Details Files
Removed explicit disconnect call in debugger shutdown
  • Deleted the raw->disconnect({}) call from the shutdown method to prevent attempts to disconnect from an already closed debugpy instance.
src/plugins/debugger/dap/debugsession.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot merged commit 82792f4 into linuxdeepin:master May 9, 2025
10 checks passed
@Zeno-sole
Copy link

/integrate

@github-actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2834
PrNumber: 2834
PrBranch: auto-integration-14969482074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants