-
Notifications
You must be signed in to change notification settings - Fork 73
fix: block when debug python code #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
disconnect to debugpy that has closed Log: Change-Id: Ia57b8165dd7d2547c5053aee1776be22d2ac8f9b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-mozart - I've reviewed your changes - here's some feedback:
- Consider adding a check for connection status to conditionally call
raw->disconnect({}), ensuring graceful shutdown is attempted ifdebugpyis still responsive.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis pull request modifies the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
/integrate |
|
AutoIntegrationPr Bot |
disconnect to debugpy that has closed
Log:
Change-Id: Ia57b8165dd7d2547c5053aee1776be22d2ac8f9b
Summary by Sourcery
Bug Fixes: