Skip to content

Conversation

@deepin-mozart
Copy link
Contributor

@deepin-mozart deepin-mozart commented Jul 9, 2025

Log:
Change-Id: I5d94bac93f14d245a9bdcdc34377a59001367201

Summary by Sourcery

Chores:

  • Remove the 'Install by Wget' choice from the RR installer notification dialog

Log:
Change-Id: I5d94bac93f14d245a9bdcdc34377a59001367201
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-mozart - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • .gitignore 文件中新增的 .cursor/ 目录可能需要确认是否确实不需要跟踪该目录。
  • reversedebugger.cpp 文件中删除了对 wget 的支持,如果这是一个有意为之的改动,需要确保相关的文档和用户指南也进行了相应的更新。
  • checkRRInstalled 函数中移除了对 wget 的支持,但 installRR 函数中仍然保留了 wget 的选项,这可能导致逻辑不一致。

是否建议立即修改:

  • 是,需要确保 .gitignore 文件中的改动是经过深思熟虑的,并且与项目的整体策略一致。
  • 是,如果移除 wget 支持是一个必要的改动,应该更新相关的文档和用户界面,以避免用户混淆。
  • 是,需要修复 installRR 函数中的逻辑问题,确保所有可能的安装选项都能正确处理。

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 9, 2025

Reviewer's Guide

This PR removes the deprecated wget-based installation path for the rr debugger, cleaning up the installRR function and notification UI to only support apt-based installation.

File-Level Changes

Change Details Files
Eliminate wget-based installer path
  • Removed the else-if branch for id == "wget" in installRR
  • Deleted TerminalService commands that downloaded and installed rr via wget
src/plugins/debugger/reversedebug/reversedebugger.cpp
Update installation notification UI
  • Modified notifyWithCallback to drop the "wget" button option
  • Updated the QStringList to only include the apt install action
src/plugins/debugger/reversedebug/reversedebugger.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot deepin-ci-robot merged commit 08f999b into linuxdeepin:master Jul 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants