refactor: [option] Migrate option management from JSON to Settings #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored option management system to use Settings class instead of direct JSON file operations. This change improves code maintainability and reusability by: - Removing OptionUtils class and its JSON parsing/writing functionality - Using Settings class for all option storage and retrieval operations - Simplifying option access through getValue/setValue methods - Removing redundant updateData() calls and JSON file operations - Adding default constructor to Settings class for flexibility - Cleaning up option access code across multiple plugins The changes affect multiple plugins including CodeEditor, CMake, Java, Python and others. All JSON file operations are now handled through the Settings class interface. Log: Refactored option management to use Settings class instead of JSON
deepin-mozart
approved these changes
Nov 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart, Kakueeen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored option management system to use Settings class instead of direct JSON
file operations. This change improves code maintainability and reusability by:
The changes affect multiple plugins including CodeEditor, CMake, Java, Python
and others. All JSON file operations are now handled through the Settings
class interface.
Log: Refactored option management to use Settings class instead of JSON