Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#469

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • config->moveToThread(DConfig::globalThread()); 可能会导致线程安全问题,需要确认 DConfig::globalThread() 是否是全局线程,并且确保所有相关的信号槽连接都在同一个线程中。
  • 使用 lambda 表达式连接信号和槽时,捕获 this 可能会导致内存泄漏,如果 owner 是一个局部变量,那么在 lambda 表达式执行完毕后,owner 可能会被销毁,导致访问空指针。

是否建议立即修改:

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants