Skip to content

Conversation

@asterwyx
Copy link
Contributor

Support VERSION file to manage DTK version.
Add workflow auto release.

Signed-off-by: Yixue Wang [email protected]

Support VERSION file to manage DTK version.
Add workflow auto release.

Signed-off-by: Yixue Wang <[email protected]>
@asterwyx asterwyx requested a review from zccrs June 12, 2025 07:14
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • .github/workflows/call-auto-release.yml文件中,workflow_dispatchworkflow_call的输入参数定义重复,可以考虑合并以简化代码。
  • CMakeLists.txt文件中,使用file(READ)读取VERSION文件并设置DTK_VERSION,这是一个好的做法,但需要确保VERSION文件的存在和正确性。
  • .reuse/dep5文件中新增了VERSION VERSION.in,需要确认这些文件是否确实需要被包含在依赖管理中。
  • .syncexclude文件中新增了VERSION,需要确认这是否符合项目的同步策略。

是否建议立即修改:

  • 是,建议立即合并重复的输入参数定义,以保持代码的简洁性。
  • 是,需要确保VERSION文件的存在和正确性,以及CMakeLists.txt中读取VERSION的方式是正确的。
  • 是,需要确认新增的文件是否确实需要被包含在依赖管理中,以及是否符合项目的同步策略。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit 4c96bd2 into linuxdeepin:master Jun 12, 2025
7 of 10 checks passed
@deepin-bot deepin-bot bot mentioned this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants