Skip to content

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#495

@github-actions
Copy link
Contributor

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/util/drecentmanager.cpp": [
        {
            "line": "        xbelEle.setAttribute(\"xmlns:mime\", \"http://www.freedesktop.org/standards/shared-mime-info\");",
            "line_number": 82,
            "rule": "S35",
            "reason": "Url link | 4072667606"
        },
        {
            "line": "        xbelEle.setAttribute(\"xmlns:bookmark\", \"http://www.freedesktop.org/standards/desktop-bookmarks\");",
            "line_number": 84,
            "rule": "S35",
            "reason": "Url link | 4f45f72048"
        },
        {
            "line": "        metadataEle.setAttribute(\"owner\", \"http://freedesktop.org\");",
            "line_number": 161,
            "rule": "S35",
            "reason": "Url link | d7e92476a4"
        }
    ]
}

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/util/drecentmanager.cpp": [
        {
            "line": "        xbelEle.setAttribute(\"xmlns:mime\", \"http://www.freedesktop.org/standards/shared-mime-info\");",
            "line_number": 82,
            "rule": "S35",
            "reason": "Url link | 4072667606"
        },
        {
            "line": "        xbelEle.setAttribute(\"xmlns:bookmark\", \"http://www.freedesktop.org/standards/desktop-bookmarks\");",
            "line_number": 84,
            "rule": "S35",
            "reason": "Url link | 4f45f72048"
        },
        {
            "line": "        metadataEle.setAttribute(\"owner\", \"http://freedesktop.org\");",
            "line_number": 161,
            "rule": "S35",
            "reason": "Url link | d7e92476a4"
        }
    ]
}

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#495
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • .packit.yaml 文件中的 files_to_sync 更改为 synced_files,确认这是否符合项目的命名规范和一致性要求。
  • CMakeLists.txt 文件中,为 dsingleton.hdthreadutils.h 设置了 SKIP_AUTOMOC 属性,确保这些文件确实不需要 MOC 处理。
  • dconfig.cpp 文件中,将 QScopedPointer 替换为 std::unique_ptr,这是一个更现代和安全的智能指针,但需要确认项目中的其他地方是否也使用了 QScopedPointer,并确保一致性。
  • dconfig.cpp 文件中,使用 file.release()cache.release() 替换了 take(),这可能会改变内存管理的行为,需要确认这是否符合预期的内存管理策略。
  • dbusbackend.cpp 文件中,使用 std::as_const 来替代 qAsConst,这是一个更现代的 C++ 特性,但需要确保编译器支持 C++17 或更高版本。
  • drecentmanager.cpp 文件中,添加了对 QTimeZone 的包含,这表明代码现在支持 Qt 6,但需要确保所有相关的代码都已经更新以适应 Qt 6 的变化。

是否建议立即修改:

  • 是,特别是涉及到智能指针和内存管理的地方,需要确保这些更改不会引入内存泄漏或其他未定义行为。
  • 对于 .packit.yamlCMakeLists.txt 文件中的更改,建议确认这些更改是否符合项目的整体规范和一致性要求。
  • 对于 dbusbackend.cppdrecentmanager.cpp 文件中的更改,需要确保这些更改不会破坏现有的功能,并且已经通过了充分的测试。

@github-actions
Copy link
Contributor

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "src/util/drecentmanager.cpp": [
        {
            "line": "        xbelEle.setAttribute(\"xmlns:mime\", \"http://www.freedesktop.org/standards/shared-mime-info\");",
            "line_number": 82,
            "rule": "S35",
            "reason": "Url link | 4072667606"
        },
        {
            "line": "        xbelEle.setAttribute(\"xmlns:bookmark\", \"http://www.freedesktop.org/standards/desktop-bookmarks\");",
            "line_number": 84,
            "rule": "S35",
            "reason": "Url link | 4f45f72048"
        },
        {
            "line": "        metadataEle.setAttribute(\"owner\", \"http://freedesktop.org\");",
            "line_number": 161,
            "rule": "S35",
            "reason": "Url link | d7e92476a4"
        }
    ]
}

@18202781743 18202781743 merged commit 7775389 into master Jul 28, 2025
14 of 15 checks passed
@18202781743 18202781743 deleted the sync-pr-495-nosync branch July 28, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants