Skip to content

Conversation

@caixr23
Copy link

@caixr23 caixr23 commented Dec 7, 2024

Do not display AlertToolTip when alertText is empty

Log:
pms: BUG-287159

Do not display AlertToolTip when alertText is empty

Log:
pms: BUG-287159
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • Loader组件的active属性中增加了对alertText.length的检查,确保只有在showAlert为真且alertText不为空时才激活Loader

是否建议立即修改:

  • 否,这次提交的修改是合理的,它确保了只有在有警告文本时才会显示警告提示。这个改动不会引入任何明显的错误,也不会对现有功能产生负面影响。因此,不需要立即进行修改。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, caixr23

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor

这个提到dtkdeclarative https://github.com/linuxdeepin/dtkdeclarative/ 项目,dtk6的只是个拷贝,会被覆盖的,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants