sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#472

Summary by Sourcery

Refactors the WindowButton component to inherit from D.IconButton and improves focus handling. Updates the TitleBar component to conditionally enable HoverHandler based on fullscreen status.

Enhancements:

• Refactor WindowButton to inherit from D.IconButton, improving code structure and reusability.
• Improve focus handling in WindowButton using a Loader and Rectangle for visual focus indication.
• Update TitleBar to conditionally enable HoverHandler based on fullscreen status, improving user experience.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request synchronizes source files from linuxdeepin/dtkdeclarative. The key changes involve refactoring the WindowButton component to inherit from D.IconButton for improved styling and focus handling, and conditionally enabling/disabling the HoverHandler in TitleBar based on fullscreen status.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Refactor WindowButton.qml to inherit from D.IconButton and improve styling.	Changed base class from Control to D.IconButton. Added topRightRadius property to handle window corner radius when not maximized or fullscreen. Introduced isOnRightEdgeOfWindow property to determine if the button is on the right edge of the window. Used D.BoxPanel for the background to allow for more flexible styling. Added a Loader to display a focus rectangle when the button has visual focus. Removed textColor and backgroundColor properties, relying on the base class for these properties. Removed the MouseArea and related signal, as this is handled by the base class.	qt6/src/qml/WindowButton.qml
Conditionally enable/disable HoverHandler in TitleBar.qml based on fullscreen status and auto-hide setting.	Set the parent of the HoverHandler to control or null based on whether the window is fullscreen and autoHideOnFullscreen is enabled. This effectively enables or disables the HoverHandler.	qt6/src/qml/TitleBar.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 在TitleBar.qml中，HoverHandler的parent属性使用了三元运算符，这可能会导致不必要的重新计算。
• WindowButton.qml中的__itemGlobalPoint计算可能存在性能问题，因为它在每次访问时都会遍历父元素链。
• WindowButton.qml中的Loader组件在active属性为true时才加载Rectangle组件，这可能会导致延迟加载，如果visualFocus属性频繁变化，可能会影响性能。
• WindowButton.qml中的D.BoxPanel组件使用了color1和color2属性，但它们的值相同，这可能是不必要的重复设置。

是否建议立即修改:
是

• 应该优化HoverHandler的parent属性设置，避免不必要的重新计算。
• 对于__itemGlobalPoint的计算，应该考虑缓存结果，避免每次访问时都进行计算。
• 对于Loader组件的使用，应该评估是否需要延迟加载，以及是否有更高效的方式来处理visualFocus的变化。
• 对于D.BoxPanel组件的color1和color2属性，如果它们总是相同的，应该移除其中一个以简化代码。

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:

Overall Comments:

• The Qt.point function in WindowButton.qml might be performance bottleneck, consider caching the result.
• In TitleBar.qml, consider using visible: __isFullScreen && autoHideOnFullscreen instead of changing the parent of HoverHandler.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Clarify using 'parent' to disable HoverHandler

Using the parent assignment as a means to conditionally disable the HoverHandler is non-standard. It might be clearer and more maintainable to bind the 'enabled' property directly to the condition.

Suggested change

	HoverHandler {
	enabled: __isFullScreen && autoHideOnFullscreen
	id: hoverHandler
	// reset it's parent to disable HoverHandler
	parent: __isFullScreen && autoHideOnFullscreen ? control : null
	}
	HoverHandler {
	id: hoverHandler
	enabled: __isFullScreen && autoHideOnFullscreen
	}