sync: from linuxdeepin/dtkdeclarative #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request synchronizes source files from linuxdeepin/dtkdeclarative. The key changes involve replacing Sequence diagram for SettingsOption value changesequenceDiagram
participant User
participant SettingsOption
participant Config
User->>SettingsOption: setValue(newValue)
SettingsOption->>SettingsOption: setValue(newValue, updateConfig=true)
alt updateConfig is true and m_config is not null
SettingsOption->>Config: setProperty(key, newValue)
end
Config-->>SettingsOption: valueChanged(key, newValue)
alt key == m_key and value.isValid()
SettingsOption->>SettingsOption: setValue(value, updateConfig=false)
SettingsOption-->>User: valueChanged(value)
end
Sequence diagram for SettingsOption resetValuesequenceDiagram
participant User
participant SettingsOption
participant Config
User->>SettingsOption: resetValue()
SettingsOption->>SettingsOption: indexOfProperty(m_config, m_key)
alt index >= 0
SettingsOption->>Config: p.reset(m_config)
else index < 0
SettingsOption->>SettingsOption: qCWarning << "The key" << m_key << "not found in the Config object:" << m_config
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like DConfigWrapper is being replaced with QObject, which is a good change to reduce custom classes.
- Consider using
QMetaProperty::writeinstead ofQObject::setPropertyfor better type safety.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| m_valueInitialized = true; | ||
| } | ||
| }); | ||
| const auto ok = connect(m_config, SIGNAL(valueChanged(QString, QVariant)), |
There was a problem hiding this comment.
suggestion: Using old signal-slot syntax.
Switching to the new function pointer based connection syntax could provide compile-time checking and improve code clarity.
Suggested implementation:
const auto ok = connect(m_config, &Config::valueChanged,
this, &SettingsOption::onValueChanged);
If m_config is not of type Config*, replace "Config" in the new connection call with the appropriate class name that declares the valueChanged signal.
| Q_EMIT valueChanged(value); | ||
| } | ||
|
|
||
| void SettingsOption::resetValue() |
There was a problem hiding this comment.
issue (complexity): Consider refactoring the repeated meta-object handling and validity checks into helper functions to reduce nesting and improve readability without changing functionality.
Consider refactoring the repeated meta-object handling and validity checks into small helper functions. This will reduce nesting and condense the logic without changing functionality. For example:
static QVariant fetchValidProperty(QObject *config, const QString &key) {
const auto value = config->property(key.toLocal8Bit());
return value.isValid() ? value : QVariant{};
}
static bool resetConfigKey(QObject *config, const QString &key) {
const int index = indexOfProperty(config, key);
if (index < 0)
return false;
const auto mo = config->metaObject();
QMetaProperty prop = mo->property(index);
if (!prop.isResettable())
return false;
return prop.reset(config);
}Then update your slot and reset methods:
void SettingsOption::onConfigValueChanged() {
const auto value = fetchValidProperty(m_config, m_key);
if (value.isValid()) {
setValue(value, false);
m_valueInitialized = true;
}
}
void SettingsOption::resetValue() {
if (!resetConfigKey(m_config, m_key)) {
qCWarning(settingLog) << "Failed to reset the key" << m_key << "on Config object:" << m_config;
}
}This consolidates the logic into concise, reusable functions and reduces the complexity of your conditional branches.
deepin-ci-robot
force-pushed
the
sync-pr-474-nosync
branch
from
76537a4 to
8c81364
Compare
Contributor
|
TAG Bot New tag: 6.0.33 |
Contributor
|
TAG Bot New tag: 6.0.34 |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#474
deepin-ci-robot
force-pushed
the
sync-pr-474-nosync
branch
from
8c81364 to
2fe3f81
Compare
Contributor
Author
deepin pr auto review关键摘要:
是否建议立即修改:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#474
Summary by Sourcery
Refactors SettingsOption and SettingsGroup to use QObject instead of DConfigWrapper for configuration, improving flexibility. It also modifies the signal emission for value changes to include the new value.
Enhancements: