sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#479

Summary by Sourcery

Enhancements:

• Modify padding logic for menu items to ensure proper spacing with indicators and submenu arrows

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request synchronizes source files from linuxdeepin/dtkdeclarative. The key change involves modifying the left and right padding calculations within the MenuItem.qml file. The padding is now calculated using Math.max to ensure a minimum padding value based on whether the menu item is mirrored or not. This change affects the visual layout of menu items, ensuring consistent spacing.

Updated class diagram for MenuItem

classDiagram
  class MenuItem {
    arrowPadding: real
    indicatorPadding: real
    leftPadding: real
    rightPadding: real
    spacing: real
    mirrored: bool
    display: enumeration
  }
  note for MenuItem "leftPadding and rightPadding calculations updated using Math.max to ensure minimum padding."

Loading

File-Level Changes

Change	Details	Files
Modified left and right padding calculations for menu items to ensure a minimum padding value.	Updated leftPadding to use Math.max to ensure it's at least DS.Style.menu.item.contentPadding when not mirrored, otherwise use arrowPadding. Updated rightPadding to use Math.max to ensure it's at least DS.Style.menu.item.contentPadding when mirrored, otherwise use arrowPadding.	qt6/src/qml/MenuItem.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 代码修改可能改变了原有的布局逻辑，需要确认新的逻辑是否符合设计要求。
• 使用 Math.max 可能会导致意外的布局行为，需要确保这是预期的效果。

是否建议立即修改:

• 是，需要确保布局逻辑的正确性和一致性，并且确认 Math.max 的使用是否符合设计意图。如果 Math.max 的使用不符合预期，应该立即修复。

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes - here's some feedback:

Overall Comments:

• The change to use Math.max makes sense, but it would be good to have a comment explaining why.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}