-
Notifications
You must be signed in to change notification settings - Fork 21
sync: from linuxdeepin/dtkdeclarative #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#488
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR syncs components from linuxdeepin/dtkdeclarative, updating the ScrollView implementation, enhancing TextArea implicit sizing, and integrating the new ScrollView into the build system and plugin registration. Class Diagram of Modified QML ComponentsclassDiagram
direction TB
class QtQuick_Templates_ScrollView {
<<QML Base Class>>
+id: control
+implicitWidth: number
+implicitHeight: number
+availableWidth: number
+availableHeight: number
+mirrored: bool
+contentWidth: number
+contentHeight: number
+leftPadding: number
+rightPadding: number
+topPadding: number
+bottomPadding: number
+leftInset: number
+rightInset: number
+topInset: number
+bottomInset: number
+implicitBackgroundWidth: number
+implicitBackgroundHeight: number
}
class ScrollView_QML {
<<Component: qt6/src/qml/ScrollView.qml>>
+implicitWidth: number // Modified formula
+implicitHeight: number // Modified formula
+D_ScrollBar_vertical: D_ScrollBar // Added
+D_ScrollBar_horizontal: D_ScrollBar // Added
}
ScrollView_QML --|> QtQuick_Templates_ScrollView : extends (Base changed from QtQuick.Controls.ScrollView)
class D_ScrollBar {
<<Component: org.deepin.dtk.ScrollBar>>
+active: bool
+parent: Control
+x: number
+y: number
+width: number
+height: number
}
ScrollView_QML "1" o-- "2" D_ScrollBar : aggregates
class QtQuick_Templates_TextArea {
<<QML Base Class>>
+implicitWidth: number
+implicitHeight: number
+contentWidth: number
+contentHeight: number
+leftPadding: number
+rightPadding: number
+topPadding: number
+bottomPadding: number
+leftInset: number
+rightInset: number
+topInset: number
+bottomInset: number
+implicitBackgroundWidth: number
+implicitBackgroundHeight: number
+placeholder_implicitWidth: number
+placeholder_implicitHeight: number
}
class TextArea_QML {
<<Component: qt6/src/qml/TextArea.qml>>
+implicitWidth: number // Modified formula
+implicitHeight: number // Modified formula
+placeholderTextPalette: D_Palette
+placeholderTextColor: color
}
TextArea_QML --|> QtQuick_Templates_TextArea : extends
class D_Palette {
<<DTK Type>>
}
TextArea_QML *-- D_Palette : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#488
Summary by Sourcery
Sync in the updated ScrollView implementation from linuxdeepin/dtkdeclarative with QML imports, sizing logic, and ScrollBar attachments, enhance TextArea's implicit sizing, and register the new ScrollView component in the build and plugin infrastructure.
New Features:
Enhancements:
Build: