sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#491

Summary by Sourcery

Sync TitleBar.qml from linuxdeepin/dtkdeclarative to improve title bar resizing and layout behavior

Enhancements:

• Use height property instead of implicitHeight to ensure proper title bar sizing when fullscreen
• Replace anchors.fill on Loader and ColumnLayout with explicit width and height assignments

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 修改了TitleBar.qml文件中的height属性绑定，从implicitHeight改为height，可能会影响布局和样式。
• Loader组件的anchors.fill属性被移除，改为分别设置width和height，这可能会改变组件的布局行为。
• ColumnLayout组件的anchors.fill属性也被移除，改为分别设置width和height，同样可能会影响布局和样式。

是否建议立即修改:

• 是

建议的修改:

• 如果修改height属性绑定是为了解决特定布局问题，建议添加注释说明原因。
• 确认修改Loader和ColumnLayout组件的布局属性是否与设计意图一致，如果是为了适应新的布局需求，确保这些修改不会导致其他组件的布局问题。
• 如果这些修改是为了修复特定的问题，建议提供相关的测试用例来验证修改后的行为是否符合预期。

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Reviewer's Guide

Synchronized TitleBar.qml from linuxdeepin/dtkdeclarative by adjusting how height is bound and replacing anchors.fill with explicit width/height settings for improved layout consistency.

Flow Diagram: Sizing Logic Change for TitleBar's Internal Components

graph TD
    Start("Sizing for Internal Component (e.g., Loader 'background') in TitleBar") --> ConfigChange{"Configuration Changed"}
    ConfigChange -- "Previous Version" --> OldConfig["anchors.fill: parent"]
    OldConfig --> OldResult["Component size fills parent"]
    ConfigChange -- "Current PR Version" --> NewConfig["width: control.width<br/>height: control.height"]
    NewConfig --> NewResult["Component size set explicitly"]

Loading

File-Level Changes

Change	Details	Files
Use explicit height property instead of implicitHeight for the title bar height binding	Removed the implicitHeight binding Introduced a direct height binding conditioned on fullscreen and visibility	qt6/src/qml/TitleBar.qml
Replace anchors.fill with explicit width and height assignments for child elements	Removed anchors.fill on both Loader and ColumnLayout Added width and height properties referencing control dimensions Dropped the redundant id on the ColumnLayout	qt6/src/qml/TitleBar.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.