-
Notifications
You must be signed in to change notification settings - Fork 21
sync: from linuxdeepin/dtkdeclarative #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideSynchronize Qt6 QML control sources from linuxdeepin/dtkdeclarative, enabling keyboard focus for CheckBox and RadioButton and updating the sync exclusion list. Class diagram for updated CheckBox and RadioButton QML componentsclassDiagram
class CheckBox {
+opacity
+D.DciIcon.mode
+D.DciIcon.theme
+focusPolicy: Qt.TabFocus
+indicator
}
class RadioButton {
+opacity
+D.DciIcon.mode
+D.DciIcon.theme
+focusPolicy: Qt.TabFocus
+icon
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#494
6e912c3 to
215a12f
Compare
deepin pr auto review代码审查意见如下: .syncexclude 文件
CheckBox.qml 文件
RadioButton.qml 文件
图标文件
通用建议
总体来说,这些更改看起来是为了提高用户交互体验和代码的一致性,但需要确保这些更改不会引入任何新的问题,并且已经通过了充分的测试。 |
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#494
Summary by Sourcery
Synchronize source files from linuxdeepin/dtkdeclarative, adding keyboard focus support to checkbox and radio button QML components and aligning sync exclusions.
Enhancements:
Chores: