sync: from linuxdeepin/dtkdeclarative #266
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#495
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR synchronizes blur enablement across QML components by exposing an enableBlur alias on FloatingPanel, updating its Loader activation to check blur validity, refactoring InWindowBlur.valid to a property alias, and temporarily disabling blur in Menu.qml to work around a known bug. Class diagram for updated blur handling in QML componentsclassDiagram
class FloatingPanel {
int blurRadius
real blurMultiplier
alias enableBlur (blur.valid)
}
class InWindowBlur {
alias multiplier (blur.blurMultiplier)
alias content (blur)
alias data (blitter.data)
alias valid (blitter.blitterEnabled)
}
class Menu {
enableBlur = false // temporarily disables blur
}
FloatingPanel --> InWindowBlur : background
InWindowBlur --> D.BackdropBlitter : blitter
Menu --> FloatingPanel : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见：
总体来说，代码的改动看起来是合理的，但需要注意与现有代码的兼容性，并确保所有相关的文档和注释都已更新。 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `qt6/src/qml/FloatingPanel.qml:44` </location>
<code_context>
Loader {
anchors.fill: parent
- active: Window.window && Window.window.color.a < 1
+ active: Window.window && Window.window.color.a < 1 && blur.valid
sourceComponent: D.ItemViewport {
anchors.fill: parent
</code_context>
<issue_to_address>
Adding 'blur.valid' to the Loader's 'active' condition may prevent fallback rendering.
Requiring 'blur.valid' may cause the Loader to remain inactive when blur is unavailable, leading to missing UI elements. If you want to show a fallback when blur is invalid, handle that case separately.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| anchors.fill: parent | ||
| active: Window.window && Window.window.color.a < 1 | ||
| active: Window.window && Window.window.color.a < 1 && blur.valid | ||
| sourceComponent: D.ItemViewport { |
There was a problem hiding this comment.
issue (bug_risk): Adding 'blur.valid' to the Loader's 'active' condition may prevent fallback rendering.
Requiring 'blur.valid' may cause the Loader to remain inactive when blur is unavailable, leading to missing UI elements. If you want to show a fallback when blur is invalid, handle that case separately.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#495
Summary by Sourcery
Synchronize blur-related updates from upstream, exposing and controlling blur validity in floating panels and menus
Bug Fixes:
Enhancements: