sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#501

Summary by Sourcery

Sync CMake build configuration with upstream dtkdeclarative by adjusting compiler and linker flags

Build:

• Remove -Wall from CMAKE_CXX_FLAGS, retaining -fPIC and -Wextra
• Drop --as-needed option from CMAKE_SHARED_LINKER_FLAGS

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide

Syncs CMakeLists.txt from upstream by refining compiler and linker flags: removing the ‘-Wall’ warning flag and the ‘--as-needed’ linker option while preserving ‘-Wextra’ and ‘-fPIC’ in the C++ build settings.

File-Level Changes

Change	Details	Files
Refine CMake C++ and linker flags to match upstream	Removed ‘-Wall’ from CMAKE_CXX_FLAGS Dropped explicit ‘--as-needed’ from linker flags Retained ‘-fPIC’ and ‘-Wextra’ in CXX flags Eliminated separate CMAKE_SHARED_LINKER_FLAGS setting	CMakeLists.txt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

代码审查意见如下：

CMakeLists.txt 文件

• 代码注释：在添加 ASAN 选项时，应该添加注释说明为什么需要这些选项，以及如何防止应用在 DEBUG 模式下退出。
• 重复代码：在多个 CMakeLists.txt 文件中禁用 RPATH，可以考虑创建一个通用的函数或宏来处理这个问题，以避免重复代码。

qt6/src/CMakeLists.txt 文件

• 代码注释：在禁用 RPATH 时，应该添加注释说明为什么需要这样做，以及这样做的影响。

qt6/src/qml/private/CMakeLists.txt 文件

• 代码注释：在禁用 RPATH 时，应该添加注释说明为什么需要这样做，以及这样做的影响。

qt6/src/qml/settings/CMakeLists.txt 文件

• 代码注释：在禁用 RPATH 时，应该添加注释说明为什么需要这样做，以及这样做的影响。

通用建议

• 代码风格：确保所有 CMakeLists.txt 文件中的代码风格一致，包括缩进和注释格式。
• 错误处理：在添加 ASAN 选项时，应该考虑如何处理可能出现的错误，例如环境变量设置失败的情况。
• 依赖管理：确保所有依赖库都在标准系统路径中，否则可能需要配置额外的路径或使用动态链接。

总的来说，这些修改提高了代码的可读性和可维护性，并且通过禁用 RPATH 来避免潜在的路径问题。但是，需要确保这些修改不会影响应用程序的正常运行。