-
Notifications
You must be signed in to change notification settings - Fork 21
sync: from linuxdeepin/dtkdeclarative #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#504
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review代码审查意见:
总体来说,这些更改提高了代码的简洁性和可维护性,但需要注意确保视觉效果和功能的一致性。 |
Reviewer's GuideUpstream synchronization replaces custom tooltip styling in AlertToolTip.qml with a reusable FloatingPanel component, refines FlowStyle palette with updated opacity and new dropShadow/insideBorder/outsideBorder colors, and simplifies Loader activation logic in FloatingPanel.qml. Class diagram for AlertToolTip background refactorclassDiagram
class AlertToolTip {
background: FloatingPanel
}
class FloatingPanel {
backgroundColor
insideBorderColor
outsideBorderColor
}
AlertToolTip --> FloatingPanel : uses
%% Previously:
class BoxShadow {
shadowBlur
shadowOffsetY
shadowColor
cornerRadius
}
class Rectangle {
backgroundColor
borderColor
color
border.color
radius
}
%% Old composition (removed):
%% AlertToolTip --> BoxShadow : used
%% AlertToolTip --> Rectangle : used
%% BoxShadow o-- Rectangle : contains
%% Now replaced by FloatingPanel
Class diagram for updated FlowStyle palette propertiesclassDiagram
class FlowStyle {
background: D.Palette
connecterdropShadow: D.Palette
dropShadow: D.Palette
outsideBorder: D.Palette
insideBorder: D.Palette
}
class D.Palette {
normal
normalDark
}
FlowStyle --> D.Palette : uses
Class diagram for FloatingPanel Loader activation logic changeclassDiagram
class FloatingPanel {
insideBorderColor
Loader.active
}
class Loader {
active
sourceComponent: InsideBoxBorder
}
FloatingPanel o-- Loader : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#504
Summary by Sourcery
Sync QML components from linuxdeepin/dtkdeclarative by integrating FloatingPanel for alert tooltips and enriching style palettes.
Enhancements: