-
Notifications
You must be signed in to change notification settings - Fork 21
sync: from linuxdeepin/dtkdeclarative #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis pull request syncs QML style definitions from linuxdeepin/dtkdeclarative by extending FlowStyle palettes with new background entries and normal colors, adjusting embeddedProgressBar color values, and refactoring ProgressBarPanel to use centralized style properties. Entity relationship diagram for FlowStyle and ProgressBarPanel palette changeserDiagram
FLOWSTYLE ||--o{ PALETTE : uses
FLOWSTYLE ||--o{ EMBEDDEDPROGRESSBAR : contains
EMBEDDEDPROGRESSBAR ||--o{ PALETTE : uses
PROGRESSBARPANEL ||--o{ RECTANGLE : contains
RECTANGLE ||--o{ PALETTE : uses
FLOWSTYLE {
string shadowInner2
string handleGradientColor
string background
}
EMBEDDEDPROGRESSBAR {
string background
string progressBackground
}
PALETTE {
string normal
string normalDark
}
PROGRESSBARPANEL {
string _normalTextComponent
}
RECTANGLE {
string backgroundColor
string color
string radius
}
Class diagram for updated FlowStyle and ProgressBarPanel QML propertiesclassDiagram
class FlowStyle {
+D.Palette shadowInner2
+D.Palette handleGradientColor
+D.Palette background (new)
+QtObject embeddedProgressBar
}
class D.Palette {
+normal
+normalDark
}
class embeddedProgressBar {
+D.Palette background (normal, normalDark updated)
+D.Palette progressBackground
}
class ProgressBarPanel {
+Component _normalTextComponent
}
class Rectangle {
+Palette backgroundColor (new)
+radius
+color (now uses ColorSelector.backgroundColor)
}
FlowStyle --> D.Palette : uses
FlowStyle --> embeddedProgressBar : contains
embeddedProgressBar --> D.Palette : uses
ProgressBarPanel --> Rectangle : contains
Rectangle --> Palette : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#505
1a32811 to
133bb82
Compare
deepin pr auto review代码审查意见:
|
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#505
Summary by Sourcery
Synchronize style definitions by adding and updating palette entries in FlowStyle.qml and refactor ProgressBarPanel.qml to leverage the new background palette property
Enhancements: