sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#510

Summary by Sourcery

Enhancements:

• Use std::round when computing vertical and horizontal centering offsets in alignedRect

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 代码质量：

   • 在计算 y 和 x 的位置时，使用了 std::round 函数来四舍五入。这可能会导致一些微小的视觉差异，因为四舍五入可能会导致像素级别的偏移。如果对精确的像素对齐有要求，建议使用 qRound 函数，它是专门为 Qt 设计的，可以确保对齐到最近的像素。

2. 代码性能：

   • 使用 std::round 函数可能会引入不必要的性能开销，特别是在频繁调用的函数中。如果性能是一个关键考虑因素，建议评估是否真的需要四舍五入，或者是否可以通过其他方式（如提前计算整数值）来避免这种开销。

3. 代码安全：

   • 代码中没有明显的安全漏洞，但是确保所有输入参数（如 rectangle 和 size）都是有效的，并且在使用之前进行了适当的检查，是非常重要的。

4. 可读性：

   • 代码的修改使得逻辑更加清晰，但是建议添加注释来解释为什么选择使用 std::round 而不是 qRound，特别是对于不熟悉这些函数的开发者来说。

综上所述，代码的修改是合理的，但是在性能和可读性方面可能需要进一步的考虑。如果对性能有严格要求，建议评估是否真的需要四舍五入，或者是否有其他方法可以避免这种开销。

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR synchronizes the alignment logic by introducing std::round calls to the center offset calculations, ensuring consistent pixel alignment.

File-Level Changes

Change	Details	Files
Apply rounding to center alignment offsets	Wrap vertical center offset calculation in std::round Wrap horizontal center offset calculation in std::round	src/private/dquickiconlabel.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}