sync: from linuxdeepin/dtkdeclarative #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR updates ComboBox.qml by introducing dynamic width management across delegate, text field, background, and popup components—enabling flat-mode sizing, adding popup margins, and ensuring list items auto-resize to fit view width. Sequence diagram for dynamic width adjustment in ArrowListViewsequenceDiagram
participant ComboBox
participant Popup
participant ArrowListView
participant ListView
participant MenuItem
ComboBox->>Popup: Open popup
Popup->>ArrowListView: Initialize contentItem
ArrowListView->>ListView: Get item count
ArrowListView->>ArrowListView: refreshContentItemWidth()
loop For each item
ArrowListView->>ListView: itemAtIndex(i)
ArrowListView->>MenuItem: Set item.width = view.width
end
ArrowListView->>ArrowListView: onWidthChanged triggers refreshContentItemWidth()
ArrowListView->>ArrowListView: Connections onCountChanged triggers refreshContentItemWidth()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `qt6/src/qml/ComboBox.qml:107` </location>
<code_context>
- Layout.fillWidth: true
+ Layout.fillWidth: !control.flat
Layout.fillHeight: true
+ implicitWidth: control.flat ? contentWidth : implicitBackgroundWidth + leftInset + rightInset
+ || contentWidth + leftPadding + rightPadding
Layout.rightMargin: DS.Style.comboBox.spacing
text: control.editable ? control.editText : control.displayText
</code_context>
<issue_to_address>
The implicitWidth assignment uses a chained logical OR, which may be error-prone.
Using '||' for fallback may result in unintended values if the first calculation is 0 or another falsy value. Please use a more explicit approach to ensure the correct width is assigned.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+107
to
+109
| implicitWidth: control.flat ? contentWidth : implicitBackgroundWidth + leftInset + rightInset | ||
| || contentWidth + leftPadding + rightPadding |
There was a problem hiding this comment.
issue: The implicitWidth assignment uses a chained logical OR, which may be error-prone.
Using '||' for fallback may result in unintended values if the first calculation is 0 or another falsy value. Please use a more explicit approach to ensure the correct width is assigned.
deepin-ci-robot
force-pushed
the
sync-pr-521-nosync
branch
2 times, most recently
from
95ee1be to
62d12dd
Compare
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#521
deepin-ci-robot
force-pushed
the
sync-pr-521-nosync
branch
from
62d12dd to
c6ff661
Compare
Contributor
Author
deepin pr auto review我对这个代码审查如下：
总体建议：
这些改进将使代码更加健壮、可维护，并提高性能。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#521
Summary by Sourcery
Synchronize ComboBox QML component updates from upstream to improve flat styling, dynamic sizing, and popup item layout.
Enhancements: