-
Notifications
You must be signed in to change notification settings - Fork 21
sync: from linuxdeepin/dtkdeclarative #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#526
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review我对这段代码审查如下:
改进建议:
// 仅在列表可交互且不在顶部时显示向上箭头
visible: itemsView.interactive && !itemsView.atYBeginning
// 仅在列表可交互且不在底部时显示向下箭头
visible: itemsView.interactive && !itemsView.atYEnd
总体而言,这是一个合理的改进,通过增加简单的条件判断,优化了用户界面的交互逻辑,使其更加符合用户预期。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR synchronizes ArrowListView.qml from the linuxdeepin repository and refines arrow button visibility by adding boundary checks, so the up arrow hides at the top and the down arrow at the bottom. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#526
Summary by Sourcery
Improve ArrowListView by showing navigation arrows only when scrolling is possible and the view is interactive.
Bug Fixes: