sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#543

Summary by Sourcery

Synchronize ScrollView.qml from upstream by migrating to QtQuick.Templates ScrollView, updating module imports, and integrating Deepin scrollbars with implicit sizing.

Enhancements:

• Migrate ScrollView to use QtQuick.Templates 2.12 and QtQuick.Controls.impl
• Introduce implicitWidth and implicitHeight calculations based on content and background in the template control
• Attach Deepin-native vertical and horizontal D.ScrollBar delegates with positioning and sizing

[sourcery-ai]

Reviewer's Guide

Refactored ScrollView.qml to synchronize with the upstream linuxdeepin/dtkdeclarative by updating imports, migrating to the QtQuick.Templates ScrollView, and integrating Deepin DTK scrollbars with custom sizing and positioning logic.

Class diagram for refactored ScrollView.qml with DTK ScrollBars

classDiagram
class T.ScrollView {
  +implicitWidth
  +implicitHeight
}
class D.ScrollBar {
  +vertical
  +horizontal
  +parent
  +x
  +y
  +width
  +height
  +active
}
T.ScrollView "1" o-- "1" D.ScrollBar : vertical
T.ScrollView "1" o-- "1" D.ScrollBar : horizontal

Loading

File-Level Changes

Change	Details	Files
Updated module imports to QtQuick 2.12 and Deepin DTK	Removed import of QtQuick.Controls 2.4 Added imports: QtQuick 2.12, QtQuick.Controls.impl 2.12, QtQuick.Templates 2.12 as T, org.deepin.dtk 1.0 as D	src/qml/ScrollView.qml
Migrated to T.ScrollView with explicit sizing	Replaced ScrollView with T.ScrollView and assigned id 'control' Added implicitWidth and implicitHeight calculations using insets and padding	src/qml/ScrollView.qml
Integrated Deepin DTK scrollbars	Defined D.ScrollBar.vertical with parent, position, height, and active binding Defined D.ScrollBar.horizontal with parent, position, width, and active binding	src/qml/ScrollView.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Double-check the implicitWidth/implicitHeight calculations to ensure edge cases (like varying content or inset sizes) are handled correctly.
• The vertical and horizontal ScrollBar ‘active’ bindings reference each other, creating a circular dependency; consider decoupling those to avoid binding loops.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Double-check the implicitWidth/implicitHeight calculations to ensure edge cases (like varying content or inset sizes) are handled correctly.
- The vertical and horizontal ScrollBar ‘active’ bindings reference each other, creating a circular dependency; consider decoupling those to avoid binding loops.

## Individual Comments

### Comment 1
<location> `src/qml/ScrollView.qml:18-23` </location>
<code_context>
+    implicitHeight: Math.max(implicitBackgroundHeight + topInset + bottomInset,
+                             contentHeight + topPadding + bottomPadding)
+
+    D.ScrollBar.vertical: D.ScrollBar {
+        parent: control
+        x: control.mirrored ? 0 : control.width - width
+        y: control.topPadding
+        height: control.availableHeight
+        active: control.D.ScrollBar.horizontal.active
+    }
+
</code_context>

<issue_to_address>
**question (bug_risk):** The vertical scrollbar's 'active' property references the horizontal scrollbar's 'active' state, which may be confusing.

Please verify if the vertical scrollbar should depend on the horizontal scrollbar's 'active' state. If independent control is intended, adjust the logic accordingly.
</issue_to_address>

### Comment 2
<location> `src/qml/ScrollView.qml:26-31` </location>
<code_context>
+        active: control.D.ScrollBar.horizontal.active
+    }
+
+    D.ScrollBar.horizontal: D.ScrollBar {
+        parent: control
+        x: control.leftPadding
+        y: control.height - height
+        width: control.availableWidth
+        active: control.D.ScrollBar.vertical.active
+    }
 }
</code_context>

<issue_to_address>
**question (bug_risk):** The horizontal scrollbar's 'active' property references the vertical scrollbar's 'active' state, which may cause circular or unintended activation.

Consider refactoring to avoid circular dependencies between scrollbar 'active' states, or add documentation if synchronization is intended.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}