-
Notifications
You must be signed in to change notification settings - Fork 21
fix: add versioned dependency for libdtk6declarative shared library #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added override_dh_makeshlibs target to generate versioned shlibs file 2. Set minimum dependency version to match major.minor.patch components of current package version 3. This ensures proper version tracking and dependency management for shared libraries Influence: 1. Verify that package builds successfully with the new shlibs override 2. Check that generated shlibs file contains correct version dependency 3. Test package installation and dependency resolution on target systems 4. Verify that dependent packages can properly link against the versioned library fix: 为 libdtk6declarative 共享库添加版本化依赖 1. 添加 override_dh_makeshlibs 目标来生成版本化的 shlibs 文件 2. 设置最小依赖版本以匹配当前包版本的主版本.次版本.修订号组件 3. 这确保了共享库的正确版本跟踪和依赖管理 Influence: 1. 验证包是否使用新的 shlibs 覆盖成功构建 2. 检查生成的 shlibs 文件是否包含正确的版本依赖 3. 在目标系统上测试包安装和依赖解析 4. 验证依赖包能否正确链接到版本化库
|
Warning
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis update enhances Debian packaging for libdtk6declarative by overriding dh_makeshlibs to emit a versioned shlibs file and aligning the minimum shlib dependency with the package’s exact major.minor.patch version, ensuring accurate library version tracking and dependency resolution. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个 debian/rules 文件的变更进行审查:
改进建议:
修改建议示例: # 提取版本号的主版本号
MAJOR_VER = $(shell echo $(VERSION) | cut -d '.' -f 1,2,3)
override_dh_makeshlibs:
dh_makeshlibs -V "libdtk6declarative (>= $(MAJOR_VER))"这样的修改:
总体来说,原始代码的功能实现是正确的,但可以通过上述改进提高代码质量和可维护性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
of current package version
shared libraries
Influence:
versioned library
fix: 为 libdtk6declarative 共享库添加版本化依赖
Influence:
Summary by Sourcery
Generate versioned shlibs and enforce matching minimum dependencies for libdtk6declarative packaging to ensure proper version tracking and downstream linking.
Bug Fixes: