Skip to content

Conversation

@18202781743
Copy link
Contributor

Drop DQuickBorderImage in qt5.

pms: BUG-291539

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#425
@18202781743
Copy link
Contributor Author

@zzxyb

Drop DQuickBorderImage in qt5.

pms: BUG-291539
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 3, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#425
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

代码审查意见:

  1. 移除未使用的头文件和类型注册

    • qmlplugin_plugin.cpp 中移除了 dquickborderimage_p.h 的包含和类型注册,这有助于减少编译时间和减少不必要的依赖。但是,如果 DBorderImage 类型在项目中不再使用,建议彻底移除相关的代码和文档,以保持代码的整洁。
  2. QML 文件中的类型名称更改

    • BoxShadow.qml 文件中,D.DBorderImage 被更改为 BorderImage。这可能是为了简化 QML 代码,但是需要确保这一更改不会影响其他依赖 DBorderImage 的地方。如果 DBorderImage 是一个自定义类型,建议在 QML 文件中明确指定其命名空间,以避免潜在的冲突。
  3. CMake 文件中的条件编译

    • src.cmake 文件中,移除了 dquickborderimage_p.hdquickborderimage.cpp 的条件编译。如果这个更改是为了支持 Qt 6,那么需要确保所有相关的代码都已经更新以兼容 Qt 6。同时,应该检查是否有其他地方依赖于 DBorderImage 类型,并确保这些依赖仍然有效。
  4. 代码注释和文档

    • dquickborderimage_p.h 文件中,移除了 QML_NAMED_ELEMENT(DBorderImage) 的条件编译。如果这个更改是有意为之,建议在代码中添加相应的注释,说明为什么需要这样做,以及这个更改对项目的影响。
  5. 潜在的编译警告

    • 如果 DBorderImage 类型在项目中不再使用,建议在移除相关代码后,运行一次完整的编译,以确保没有遗漏的依赖或未处理的警告。

总体来说,这些更改看起来是为了清理和简化代码,但是需要确保这些更改不会引入新的问题,并且所有相关的依赖和文档都已经更新。

@kegechen
Copy link
Contributor

kegechen commented Dec 3, 2024

/+1

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit af10434 into linuxdeepin:master Dec 3, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants