Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Jan 3, 2025

Removing warning.

pms: TASK-368399

@18202781743 18202781743 requested a review from mhduiy January 3, 2025 05:47
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 3, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 3, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
@mhduiy
Copy link
Contributor

mhduiy commented Jan 6, 2025

pms 不应该是一个task吗

mhduiy
mhduiy previously approved these changes Jan 7, 2025
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
@18202781743
Copy link
Contributor Author

/check all

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 7, 2025

Deepin Obs Bot
Starting find obs webhook event and retrigger!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
Removing warning.

pms: TASK-368399
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • dquickextendregister_p.h文件中新增了dqmlglobalobject_p.h的引用,需要确认是否有必要,以及是否遵循了项目的依赖管理规则。
  • DColorForeign命名空间中新增了QML_NAMED_ELEMENT(Color)QML_FOREIGN_NAMESPACE(DTK_QUICK_NAMESPACE::DColor),需要检查这些宏的正确性和必要性。
  • DPlatformHandleForeign结构体中新增了QML_UNCREATABLE("PlatformHandle"),需要确认这一改动是否符合业务逻辑需求。
  • DColor类中移除了QML_ANONYMOUSQML_NAMED_ELEMENT(Color)QML_UNCREATABLE("Color is only available as enums."),并新增了QML_VALUE_TYPE(dcolor),需要验证这一改动是否与类的定义和用途一致。

是否建议立即修改:

  • 是,需要确保所有新增的宏和命名空间的使用都是必要的,并且与项目的其他部分保持一致。同时,需要验证所有改动是否符合业务逻辑和代码规范。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
@18202781743 18202781743 requested a review from mhduiy January 7, 2025 06:33
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 78f298e into linuxdeepin:master Jan 7, 2025
19 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants