-
Notifications
You must be signed in to change notification settings - Fork 42
fix: use applicationDisplayName instead of qAppName in DQMLGlobalObject #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed qAppName() to qApp->applicationDisplayName() when sending system notifications to use the display name rather than the executable name. This provides better user experience as display names are typically more readable and user-friendly than raw executable names. The change affects the notification sender configuration in DQMLGlobalObject's sendSystemMessage method. fix: 在DQMLGlobalObject中使用applicationDisplayName替代qAppName 将发送系统通知时的qAppName()改为qApp->applicationDisplayName(),以 使用显示名称而非可执行文件名。这提供了更好的用户体验,因为显示名称通 常比原始可执行文件名更易读和用户友好。此修改影响了DQMLGlobalObject的 sendSystemMessage方法中的通知发送器配置。
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#484
Reviewer's GuideThe PR updates the system notification sender in DQMLGlobalObject to use the application’s display name instead of the raw executable name, improving user readability. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } | ||
| } | ||
|
|
||
| void DQMLGlobalObject::sendSystemMessage(const QString &summary, const QString &body, const QString &appIcon, const QStringList &actions, const QVariantMap hints, const int timeout, const uint replaceId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Pass hints by const reference to avoid copying
Update the parameter to 'const QVariantMap& hints' to avoid unnecessary copies.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#484
deepin pr auto review关键摘要:
是否建议立即修改:
|
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#484
Changed qAppName() to qApp->applicationDisplayName() when sending system
notifications to use the display name rather than the executable name.
This provides better user experience as display names are typically
more readable and user-friendly than raw executable names. The change
affects the notification sender configuration in DQMLGlobalObject's
sendSystemMessage method.
fix: 在DQMLGlobalObject中使用applicationDisplayName替代qAppName
将发送系统通知时的qAppName()改为qApp->applicationDisplayName(),以
使用显示名称而非可执行文件名。这提供了更好的用户体验,因为显示名称通
常比原始可执行文件名更易读和用户友好。此修改影响了DQMLGlobalObject的
sendSystemMessage方法中的通知发送器配置。
Summary by Sourcery
Enhancements: