Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented May 15, 2025

Changed qAppName() to qApp->applicationDisplayName() when sending system
notifications to use the display name rather than the executable name.
This provides better user experience as display names are typically
more readable and user-friendly than raw executable names. The change
affects the notification sender configuration in DQMLGlobalObject's
sendSystemMessage method.

fix: 在DQMLGlobalObject中使用applicationDisplayName替代qAppName

将发送系统通知时的qAppName()改为qApp->applicationDisplayName(),以
使用显示名称而非可执行文件名。这提供了更好的用户体验,因为显示名称通
常比原始可执行文件名更易读和用户友好。此修改影响了DQMLGlobalObject的
sendSystemMessage方法中的通知发送器配置。

Summary by Sourcery

Enhancements:

  • Switch system notification sender to use qApp->applicationDisplayName() instead of qAppName()

Changed qAppName() to qApp->applicationDisplayName() when sending system
notifications to use the display name rather than the executable name.
This provides better user experience as display names are typically
more readable and user-friendly than raw executable names. The change
affects the notification sender configuration in DQMLGlobalObject's
sendSystemMessage method.

fix: 在DQMLGlobalObject中使用applicationDisplayName替代qAppName

将发送系统通知时的qAppName()改为qApp->applicationDisplayName(),以
使用显示名称而非可执行文件名。这提供了更好的用户体验,因为显示名称通
常比原始可执行文件名更易读和用户友好。此修改影响了DQMLGlobalObject的
sendSystemMessage方法中的通知发送器配置。
@18202781743 18202781743 requested review from BLumia and mhduiy May 15, 2025 05:07
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#484
@sourcery-ai
Copy link

sourcery-ai bot commented May 15, 2025

Reviewer's Guide

The PR updates the system notification sender in DQMLGlobalObject to use the application’s display name instead of the raw executable name, improving user readability.

File-Level Changes

Change Details Files
Use applicationDisplayName for notification app name
  • Replaced .appName(qAppName()) with .appName(qApp->applicationDisplayName()) in sendSystemMessage
src/private/dqmlglobalobject.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

}
}

void DQMLGlobalObject::sendSystemMessage(const QString &summary, const QString &body, const QString &appIcon, const QStringList &actions, const QVariantMap hints, const int timeout, const uint replaceId)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Pass hints by const reference to avoid copying

Update the parameter to 'const QVariantMap& hints' to avoid unnecessary copies.

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#484
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • qApp->applicationDisplayName() 应该在调用之前检查 qApp 是否为空,以避免潜在的空指针异常。

是否建议立即修改:

@18202781743 18202781743 merged commit 4c08a0e into linuxdeepin:master May 15, 2025
17 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants